addressed review comments

zingolabs · Oct 1, 2024 · a413347 · a413347
1 parent 1874936
commit a413347
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/zingolib/src/testutils/chain_generics/fixtures.rs b/zingolib/src/testutils/chain_generics/fixtures.rs
@@ -611,11 +611,6 @@ where
 
     let mut expected_fee = fee_tables::one_to_one(Some(Orchard), pool, true);
 
-    // why?
-    if pool == Shielded(Sapling) {
-        expected_fee -= 10_000
-    }
-
     assert_eq!(
         from_inputs::propose(
             &ref_secondary,

diff --git a/zingolib/src/wallet/describe.rs b/zingolib/src/wallet/describe.rs
@@ -313,11 +313,13 @@ mod test {
 
     use crate::wallet::LightWallet;
 
-    // these functions are tested gold and a better pattern for address lookup.
-    // maybe later they can be gated in.
+    /// these functions have clearer typing than
+    /// the production functions using json that could be upgraded soon
     impl LightWallet {
         #[allow(clippy::result_unit_err)]
-        /// gets a UnifiedAddress, the first the wallet. this is the only receiver implemented as 2024-09-22
+        /// gets a UnifiedAddress, the first of the wallet.
+        /// zingolib includes derivations of further addresses. however, these are broken
+        /// ZingoMobile uses one address.
         pub fn get_first_ua(&self) -> Result<zcash_keys::address::UnifiedAddress, ()> {
             Ok(self
                 .wallet_capability()