added LightWallet::get_first_address #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluidvanadium
requested review from
pacu,
zancas,
sebastianlujan,
Edicksonjga,
juanky201271,
AloeareV,
nachog00,
dorianvp,
Oscar-Pepper and
idky137
pacu
suggested changes
Sep 23, 2024
fluidvanadium
changed the title
fluidvanadium
force-pushed
the
wallet_base_address
branch
from
6811a16
to
4c4a508
Compare
This was referenced Sep 24, 2024
zancas
reviewed
Sep 28, 2024
zancas
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this PR merges, all methods to receive an address are methods of LightClient. even though a LightWallet contains an address.
fixes above.