-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This will break after React 16.4.0 #121
Comments
Hi @gaearon, thanks for letting us know. You've already warned for this in #112 so we knew this was coming. We're not planning on supporting >=16.4 and will make this clear in the README. I think it's time to move away from this plugin anyway since the problem has gone away mostly. |
Lol I forgot about that issue, sorry for the spam. Feel free to close :-) |
No worries, thanks for the reminder 😄 You suggested turning this plugin into a I've already experimented with a userland So I think it's time to end this plugin. |
Everything will come to an end. Anyway, it works good on my app. Thank you very much! |
I am using react 16.0.0 on an old project but it wont work ... |
Incompatible with newer react and probably unnecessary. See: zilverline/react-tap-event-plugin#121
We renamed some of the internal top level types in facebook#12629 so the plugin in its current form will break. It's not a semver-major change because this plugin was never supported officially and relies on private APIs that can change in any patch.
The text was updated successfully, but these errors were encountered: