NPM update #161

danielweck · 2018-06-19T07:49:53Z

NPM lockfile now aligned with r2-xxx-js packages.
Removed r2-testapp-js dependency (not needed in readium-electron).
Minor: added package.json script "package:pack-only" for electron-builder (a separate branch will be created later, for the customized ASAR build process)

Please merge this as soon as possible to avoid future branch conflicts :)
(if you approve, of course)

…endency (not needed in readium-electron)

danielweck · 2018-06-19T12:26:16Z

I am getting a build failure on Linux (fine on MacOS) ... investigating :(

danielweck · 2018-06-19T13:15:02Z

Linux failure (TypeScript compiler / WebPack loader):
https://travis-ci.org/readium/readium-desktop/builds/393987949#L1461

Works fine on MacOS, so I compared the contents of the node_modules in particular the r2-xxx-js packages, and they seem duplicated in Linux (whereas they are correctly organised in MacOS). Same Node and NPM versions. I will try downgrading NPM, as this is usually the culprit.

danielweck · 2018-06-19T13:43:02Z

Downgrading from NPM 6.* to 5.* seems to fix this. If this is confirmed, I am going to adjust the TravisCI YAML script to ensure we can build PRs...

danielweck · 2018-06-19T13:50:15Z

Just as I suspected, npm ci works on 6.* when used instead of npm install.

… ci instead of npm install ... let's see.

danielweck · 2018-06-19T14:26:58Z

Travis CI now passes :)
(phew!)

danielweck · 2018-07-02T14:57:18Z

Note that react-dropzone version 4.2.12 introduces a regression bug (invisible publication library, yet each cover item is in the DOM), so we stick to 4.2.11.

…locator API. Backend database / store currently remains with only CSS selector support (string)

danielweck · 2018-08-14T12:03:02Z

Note that the react-dropzone version 4.2.12+ regression bug still exists (invisible publication library, yet each cover item is in the DOM), so we stick to 4.2.11 (latest is 4.3.0).
See:
react-dropzone/react-dropzone#631

leomoty · 2018-08-14T12:35:21Z

react-tap-event-plugin is not compatible with react >= 16.4, nor they plan on supporting it. Found this while I was looking how to compile the project itself.

zilverline/react-tap-event-plugin#121

leomoty · 2018-08-14T12:39:00Z

Also, should be a simple fix:

npm WARN deprecated [email protected]: You can now upgrade to @material-ui/core

danielweck · 2018-08-14T13:21:11Z

Thank you for the heads-up about "react-tap-event-plugin". As people have stated in the issue tracker ( zilverline/react-tap-event-plugin#121 ): "this plugin was never supported officially and relies on private APIs that can change in any patch", and "I think it's time to end this plugin" :)
More importantly, there will soon be major changes to the readium-desktop UI (as per the plan to redesign for better visuals and accessibility) so I wouldn't worry too much about the current alpha UI state.

danielweck · 2018-08-14T13:38:50Z

Regarding @material-ui/core: just to clarify, the purpose of this PR is to ensure that the r2-xxx-js dependencies are up to date (which sometimes requires code changes in readium-desktop), and also to make sure that common / shared dependencies with readium-desktop are aligned. This way, the package-lock.json file is consistent across the board, and the dependencies expressed in package.json explicitly reference their actual semver (current node_modules packages as per the NPM lockfile).

Note that I use the NCU utility to check for the latest available versions (minor and major updates). The goal is to explicitly include minor changes (to stay in sync with security updates, bug fixes, improvements, etc.), whilst filtering-out known breaking API updates. In the latter case, the 4.x.x semver notation is used instead of ^4.0.0 (for example) which gives developers a strong visual cue that some dependencies break the build (and it makes it easy to use NCU with its "exclude" flag, e.g. ncu -a -u -x electron,webpack,webpack-dev-server,etc).

So, thank you for the heads-up about @material-ui/core, but I think it is fine for now as the UI redesign will probably shake things quite a bit (including the Material deps). Cheers! :)

leomoty · 2018-08-14T13:39:08Z

@danielweck I am not really worried about the UI itself, I am trying to build the LCP stack, but so far I am not sure whether my .lcpl license file works or not. I tried building readium-desktop from source without success. The alpha binary works, but I cant seem to open the epub, nor does it echo any error that could help.

danielweck · 2018-08-14T13:43:17Z

@leomoty here is a copy-paste of the error you mentioned here #162 (comment) :

  ERROR in [at-loader] ./src/renderer/components/ReaderApp.tsx:295:33 
        TS2345: Argument of type '(docHref: string, docSelector: string) => void' is not assignable to parameter of type '(docHref: string, locator: IEventPayload_R2_EVENT_READING_LOCATION) => void'.
      Types of parameters 'docSelector' and 'locator' are incompatible.
        Type 'IEventPayload_R2_EVENT_READING_LOCATION' is not assignable to type 'string'.
    
    ERROR in [at-loader] ./src/renderer/components/ReaderApp.tsx:671:13 
        TS2345: Argument of type 'string' is not assignable to parameter of type 'IEventPayload_R2_EVENT_READING_LOCATION'.

Are you sure you have a clean Git local copy of the branch? (please git pull && git status just to make sure everything looks good)

leomoty · 2018-08-14T13:44:00Z

git pull
Already up to date.
Current branch feature/npm-update-packs is up to date.

git status
On branch feature/npm-update-packs
Your branch is up to date with 'origin/feature/npm-update-packs'.

nothing to commit, working tree clean

leomoty · 2018-08-14T13:51:04Z

Trying to clone again on Windows

L:\>npm --version
6.1.0

L:\>node --version
v10.6.0

Will report back after npm install runs.

leomoty · 2018-08-14T13:56:00Z

npm install is so much better:

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

added 1824 packages from 1446 contributors and audited 19709 packages in 417.952s
found 0 vulnerabilities

Errors have changed:

[2] ERROR in [at-loader] ./src/main/redux/sagas/lcp.ts:74:21
[2]     TS2345: Argument of type 'import(".../readium-desktop/node_modules/r2-streamer-js/dist/es6-es2015/src/http/server").Server' is not assignable to parameter of type 'import(".../readium-desktop/node_modules/r2-navigator-js/node_modules/r2-streamer-js/dist/es6-es2015/src/http/server").Server'.
[2]
[2] ERROR in [at-loader] ./src/main/redux/sagas/lcp.ts:135:21
[2]     TS2345: Argument of type 'import(".../readium-desktop/node_modules/r2-streamer-js/dist/es6-es2015/src/http/server").Server' is not assignable to parameter of type 'import(".../readium-desktop/node_modules/r2-navigator-js/node_modules/r2-streamer-js/dist/es6-es2015/src/http/server").Server'.
[2]
[2] ERROR in [at-loader] ./src/main/streamer.ts:37:20
[2]     TS2345: Argument of type 'import(".../readium-desktop/node_modules/r2-streamer-js/dist/es6-es2015/src/http/server").Server' is not assignable to parameter of type 'import(".../readium-desktop/node_modules/r2-navigator-js/node_modules/r2-streamer-js/dist/es6-es2015/src/http/server").Server'.
[2]
[2] ERROR in [at-loader] ./src/main/streamer.ts:51:17
[2]     TS2345: Argument of type 'import(".../readium-desktop/node_modules/r2-streamer-js/dist/es6-es2015/src/http/server").Server' is not assignable to parameter of type 'import(".../readium-desktop/node_modules/r2-navigator-js/node_modules/r2-streamer-js/dist/es6-es2015/src/http/server").Server'.
[2]   Types have separate declarations of a private property 'publications'.
[2]
[2] ERROR in [at-loader] ./src/renderer/components/ReaderApp.tsx:679:13
[2]     TS2345: Argument of type 'import(".../readium-desktop/node_modules/r2-shared-js/dist/es6-es2015/src/models/publication").Publication' is not assignable to parameter of type 'import(".../readium-desktop/node_modules/r2-navigator-js/node_modules/r2-shared-js/dist/es6-es2015/src/models/publication").Publication'.
[2]   Types have separate declarations of a private property 'Internal'.
[2]
[2] ERROR in [at-loader] ./src/utils/lcp.ts:115:17
[2]     TS2345: Argument of type 'import(".../readium-desktop/node_modules/r2-shared-js/node_modules/r2-lcp-js/dist/es6-es2015/src/parser/epub/lcp").LCP' is not assignable to parameter of type 'import(".../readium-desktop/node_modules/r2-lcp-js/dist/es6-es2015/src/parser/epub/lcp").LCP'.
[2]   Types have separate declarations of a private property '_usesNativeNodePlugin'.

I just omitted my absolute path, everything else is verbatim.

danielweck · 2018-08-14T13:56:21Z

Note that I've had build failures in the past with NodeJS version 10+, so nowadays I stick to LTS version 8 on Linux, MacOS and Windows. NPM however is latest 6.3.0 (via npm --global update npm after installing the official NodeJS distribution). The Electron 1.x.x runtime is actually NodeJS 8 so this is another reason why I like to run all my r2-streamer-js tests on the same LTS version.

danielweck · 2018-08-14T14:01:07Z

Note that the r2-xxx-js package.json dependencies in master, develop and this PR branch feature/npm-update-packs all point to the same Git "commit-ish" reference (i.e. develop named branch/tag inside special "dist" repositories which are used instead of npmjs.com to publish builds):
https://github.com/readium/readium-desktop/blob/master/package.json#L127
https://github.com/readium/readium-desktop/blob/develop/package.json#L134
https://github.com/readium/readium-desktop/blob/feature/npm-update-packs/package.json#L136
...but the package-lock.json actual revision should take precedence when invoking npm install or npm ci. Seems to work fine with NPM 6+, and used to work with v5.

danielweck · 2018-08-14T14:04:40Z

It is worth noting that TravisCI (Linux) successfully builds this PR branch feature/npm-update-packs using NodeJS LTS v8.11.3 and the latest NPM v6.3.0.

See:
https://travis-ci.org/readium/readium-desktop/builds/415887205

leomoty · 2018-08-14T14:09:21Z

I am currently running npm install both with LTS node and latest NPM.

leomoty · 2018-08-14T14:19:02Z

Still getting the same error, however, running npm list I noticed this:

These are not necessarily all errors, but I am under impression all yours are marked as ìnvalid`.

leomoty · 2018-08-14T14:22:55Z

It doesn't seem to be first level packages tho:

npm list | Select-String -Pattern invalid

| +-- [email protected] invalid (github:edrlab/r2-utils-js-dist#812b725435a898622831724b698f41a238ac2539)
| +-- [email protected] invalid (github:danielweck/ta-json#9938af9c192ca36aa600f2ce14eb5735aa1a50e6)
| +-- [email protected] invalid (github:marcj/css-element-queries#e1f3e0475a52b830d4b6490abd7b2984fbc8553f)
| +-- [email protected] invalid (github:edrlab/r2-lcp-js-dist#0ca8931c2f5b0c4d290d9bba1542e27188af0bfe)
| +-- [email protected] invalid (github:edrlab/r2-opds-js-dist#005396ae530b8a3595cce2e32be4b676dc4acb97)
| +-- [email protected] invalid (github:edrlab/r2-shared-js-dist#6e6c2db73524190b31d56b979b740812113269e6)
| +-- [email protected] invalid (github:edrlab/r2-streamer-js-dist#ea8fcc1e8c46e7febdce6ab2dc570cd31b09b173)
| +-- [email protected] invalid (github:edrlab/r2-utils-js-dist#812b725435a898622831724b698f41a238ac2539)
| +-- [email protected] invalid (github:normanzb/resize-sensor#4cbb8ec7f454c985f2b89672afb46d8cbcf89497)
| +-- [email protected] invalid (github:danielweck/ta-json#9938af9c192ca36aa600f2ce14eb5735aa1a50e6)
| +-- [email protected] invalid (github:edrlab/r2-utils-js-dist#812b725435a898622831724b698f41a238ac2539)
| +-- [email protected] invalid (github:danielweck/ta-json#9938af9c192ca36aa600f2ce14eb5735aa1a50e6)
| +-- [email protected] invalid (github:edrlab/r2-lcp-js-dist#0ca8931c2f5b0c4d290d9bba1542e27188af0bfe)
| +-- [email protected] invalid (github:edrlab/r2-opds-js-dist#005396ae530b8a3595cce2e32be4b676dc4acb97)
| +-- [email protected] invalid (github:edrlab/r2-utils-js-dist#812b725435a898622831724b698f41a238ac2539)
| +-- [email protected] invalid (github:danielweck/ta-json#9938af9c192ca36aa600f2ce14eb5735aa1a50e6)
| +-- [email protected] invalid (github:edrlab/r2-lcp-js-dist#0ca8931c2f5b0c4d290d9bba1542e27188af0bfe)
| +-- [email protected] invalid (github:edrlab/r2-opds-js-dist#005396ae530b8a3595cce2e32be4b676dc4acb97)
| +-- [email protected] invalid (github:edrlab/r2-shared-js-dist#6e6c2db73524190b31d56b979b740812113269e6)
| +-- [email protected] invalid (github:edrlab/r2-utils-js-dist#812b725435a898622831724b698f41a238ac2539)
| +-- [email protected] invalid (github:danielweck/ta-json#9938af9c192ca36aa600f2ce14eb5735aa1a50e6)
| +-- [email protected] invalid (github:danielweck/ta-json#9938af9c192ca36aa600f2ce14eb5735aa1a50e6)

leomoty · 2018-08-14T14:29:15Z

Okay, I was able to successfully load it:

 npm update

+ [email protected]
+ [email protected]
+ [email protected]
+ [email protected]
+ [email protected]
+ [email protected]
+ [email protected]
+ [email protected]
removed 70 packages, updated 9 packages, moved 2 packages and audited 19709 packages in 32.054s
found 0 vulnerabilities

It compiled now. I have no clue what is the issue, but running npm update fixed it.

danielweck · 2018-08-14T14:30:19Z

Makes sense. Not.

leomoty · 2018-08-14T14:33:55Z

Also, I know for sure it is my issue now, I guess:

[2] ## downloadContent err

I think some config from config.yaml at lcp-server README could be outdated or something, but I am not 100% sure how to define license.links.publication. I am currently testing with the Frontend app, by the way.

danielweck · 2018-08-14T14:35:03Z

Thank you for your debunking of this NPM issue. So it is now quite clear that GitHub dependencies ( as officially supported by NPM https://docs.npmjs.com/cli/install ) are problematic, requiring an extra npm update PACKAGE_NAME for each culprit (or a more general npm update which could be problematic because this would affect other non-GitHub packages, and potentially modify the package-lock.json)

leomoty · 2018-08-14T14:53:33Z

@danielweck this is not the first time I have issues with npm, which is why I guess people suggests yarn? I can't say for sure, never used it myself. I'll try to go back to make the readium-desktop read my encrypted epub file. Thank you!

danielweck · 2018-08-14T15:20:35Z

@leomoty can you please log an issue at https://github.com/edrlab/r2-lcp-js/
(I will be happy to discuss LCP integration there)

leomoty · 2018-08-14T15:28:09Z

Done, readium/r2-lcp-js#2

danielweck · 2018-08-21T21:01:16Z

I filed a separate issue regarding Material-UI:
#164

…te minor versions here in readium-desktop

…ters)

…eaks TypeScript check in typings!)

NPM update in sync with r2-xxx-js packages, removed r2-testapp-js dep…

1429c05

…endency (not needed in readium-electron)

danielweck requested a review from clebeaupin June 19, 2018 07:49

npm update (added TA JSON)

b0a7770

NPM package lock update

e2d855f

TravisCI with correct NodeJS 8.*, and attempt to use NPM 6.* with npm…

ff687d2

… ci instead of npm install ... let's see.

danielweck added 3 commits June 21, 2018 02:44

npm update r2-xxx-js

22a8c62

npm update r2-xxx-js

96e7222

npm update with latest r2-xxx-js dependencies aligned.

9ac5a39

danielweck mentioned this pull request Jun 27, 2018

cloned project and it fails to build with npm start #151

Closed

danielweck added 6 commits July 2, 2018 15:59

react-dropzone regression

bbe7296

npm update with latest r2-xxx-js packages (minor deps update)

0810991

npm update

ff860dc

npm update (watch out for react-dropzone/react-dropzone#631 )

5a891c6

r2-navigator-js update for CSS(selector) and CFI "bookmark" document …

068fd22

…locator API. Backend database / store currently remains with only CSS selector support (string)

fixed minor import order (TS LINT)

4cbf9b2

danielweck mentioned this pull request Aug 14, 2018

epub import do nothing #162

Closed

leomoty mentioned this pull request Aug 14, 2018

LCP Integration readium/r2-lcp-js#2

Closed

danielweck added 4 commits August 23, 2018 09:39

latest NPM updates to align with r2-xxx-js packages, and also to upda…

60282a9

…te minor versions here in readium-desktop

latest updates (notably: init-globals API for JSON/XML factory conver…

c153d40

…ters)

latest updates (note the react focus lock dependency: version 0.12 br…

dbb4c20

…eaks TypeScript check in typings!)

npm update with new r2-xxx-js NPM registry packages

91335f9

clebeaupin merged commit dfdb4f4 into develop Sep 5, 2018

danielweck deleted the feature/npm-update-packs branch September 19, 2018 08:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NPM update #161

NPM update #161

danielweck commented Jun 19, 2018

danielweck commented Jun 19, 2018

danielweck commented Jun 19, 2018

danielweck commented Jun 19, 2018

danielweck commented Jun 19, 2018

danielweck commented Jun 19, 2018

danielweck commented Jul 2, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

danielweck commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 21, 2018

NPM update #161

NPM update #161

Conversation

danielweck commented Jun 19, 2018

danielweck commented Jun 19, 2018

danielweck commented Jun 19, 2018

danielweck commented Jun 19, 2018

danielweck commented Jun 19, 2018

danielweck commented Jun 19, 2018

danielweck commented Jul 2, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

danielweck commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 14, 2018

leomoty commented Aug 14, 2018

danielweck commented Aug 21, 2018