[react-v16] Part I: Basics

[bchrobot]

This has just the bare bones, no complications dependency updates. This breaks up PR #627 into 3 sub-PRs. Because of various breaking changes, I believe Spoke will not run until they are all updated in lockstep, but at least the functionality changes are broken up into more easily reviewed segments:

• material-ui - see Update material-ui to v1.2 bchrobot/Spoke#2
• react-router - see Update react-router to v4.3 bchrobot/Spoke#4
• react-apollo - see [WIP] Update react-apollo to v2.1 bchrobot/Spoke#5
• webpack + react-hot-loader - see [WIP] webpack bchrobot/Spoke#6

The above PRs are against the branch for this PR.

[bchrobot]

I have made decent progress on this. Things I am stuck on / would like feedback before continuing are:

• How to handle the removal of the react-router's match() utility method used for server-side rendering. See my comment here.
• Sanity check on webpack upgrade. Documentation is mixed. See that PR.
• General react-apollo plumbing (see that commit).
• Rewrite of loadData HOC (see that commit).

[schuyler1d]

this is fine to go into react-v16 branch.

Have you tested that the onClick works on mobile devices? I believe we moved away from click specifically because of an issue with some mobile devices.

[bchrobot]

I have not tested it on mobile yet. But will as soon as there is a running version of the v16 branch.

react-tap-event-plugin is officially deprecated though:

React 16.4 removes a lot of internals (#121) this plugin depends on and will break the plugin.

Since the problem it solves has been fixed in most browsers by now you should migrate away from this plugin.

-- https://github.com/zilverline/react-tap-event-plugin#deprecated

[schuyler1d]

For the match stuff in router, I would just skip the server-side stuff. just render the client all the time, and then let's have the client say it's wrong. (That can be a separate PR separate from react-v16 just simplifying it.)

[bchrobot]

Yeah, that's what I do in the react-router PR: https://github.com/MoveOnOrg/Spoke/pull/745/files#diff-727d7d85bce5c6c73597e64340f1c88bR33