Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] webpack #6

Open
wants to merge 4 commits into
base: react-v16-upgrade
Choose a base branch
from
Open

[WIP] webpack #6

wants to merge 4 commits into from

Conversation

bchrobot
Copy link
Owner

@bchrobot bchrobot commented Jul 6, 2018 •
edited
Loading

react-hot-loader upgrade is a mix of instructions from:

Ex. the use of the hot HOC is listed as preferred in the repo's readme but not mentioned at all in the official documentation.

This was referenced Jul 6, 2018
Open
Merged
@bchrobot
Copy link
Owner Author

bchrobot commented Jul 7, 2018

Stuck getting the response Error occured while trying to proxy to: localhost:3000/ because of the removal of the react-router's match() utility method used for server-side rendering. See my comment here.

harpojaeger
harpojaeger reviewed Jul 8, 2018
View reviewed changes
webpack/config.js
pure_getters: true,
// unsafe: true,
// unsafe_comps: true,
screw_ie8: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harpojaeger harpojaeger harpojaeger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bchrobot @harpojaeger