-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zig build: run steps in parallel #14647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
added
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
zig build system
std.Build, the build runner, `zig build` subcommand, package management
labels
Feb 14, 2023
andrewrk
force-pushed
the
build-parallel
branch
from
February 16, 2023 22:27
b723cb0
to
1fc5517
Compare
andrewrk
force-pushed
the
build-parallel
branch
2 times, most recently
from
February 21, 2023 17:32
0589977
to
f9ceb2b
Compare
andrewrk
force-pushed
the
build-parallel
branch
7 times, most recently
from
March 7, 2023 07:51
07a4545
to
6c14064
Compare
This was referenced Mar 7, 2023
This was referenced Mar 8, 2023
andrewrk
force-pushed
the
build-parallel
branch
3 times, most recently
from
March 10, 2023 05:21
4deabd3
to
0360628
Compare
andrewrk
force-pushed
the
build-parallel
branch
2 times, most recently
from
March 12, 2023 07:43
4d83076
to
1b8da32
Compare
andrewrk
force-pushed
the
build-parallel
branch
from
March 13, 2023 21:44
1b8da32
to
711c004
Compare
andrewrk
force-pushed
the
build-parallel
branch
from
March 14, 2023 18:44
ec5f775
to
51a7ffe
Compare
This was referenced Mar 17, 2023
sterchelen
added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 17, 2023
As part of ziglang/zig#14647 and more specifically this zig commit ziglang/zig@bf73620, the color is now communicated via env vars.
sterchelen
added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 17, 2023
As part of ziglang/zig#14647 and more specifically this zig commit ziglang/zig@bf73620, the color is now communicated via env vars. Signed-off-by: Nicolas Sterchele <[email protected]>
sterchelen
added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 18, 2023
Step's Options introduced from the following PR ziglang/zig#14647 and more precisely this commit ziglang/zig@02381c0
sterchelen
added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 18, 2023
Step's Options introduced from the following PR ziglang/zig#14647 and more precisely this commit ziglang/zig@02381c0 Also, MakeFn now takes a std.Progress.Node introduces by ziglang/zig@0e07879
sterchelen
added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 18, 2023
As part of ziglang/zig#14647 and more specifically this zig commit ziglang/zig@bf73620, the color is now communicated via env vars. Signed-off-by: Nicolas Sterchele <[email protected]>
sterchelen
added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 18, 2023
Step's Options introduced from the following PR ziglang/zig#14647 and more precisely this commit ziglang/zig@02381c0 Also, MakeFn now takes a std.Progress.Node introduces by ziglang/zig@0e07879
This was referenced Mar 19, 2023
sterchelen
added a commit
to sterchelen/zig
that referenced
this pull request
Mar 20, 2023
Follow-up actions from ziglang#14647 Fixes ziglang#14947
sterchelen
added a commit
to sterchelen/zig
that referenced
this pull request
Mar 20, 2023
Follow-up actions from ziglang#14647 Fixes ziglang#14947
sterchelen
added a commit
to sterchelen/zig
that referenced
this pull request
Apr 28, 2023
Follow-up actions from ziglang#14647 Fixes ziglang#14947
sterchelen
added a commit
to sterchelen/zig
that referenced
this pull request
May 2, 2023
Follow-up actions from ziglang#14647 Fixes ziglang#14947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
zig build system
std.Build, the build runner, `zig build` subcommand, package management
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, after this PR, when you run
zig build
, it will actually use all your cores to do stuff in parallel.After fixing any issues that crop up in zig's own build script, this should reduce the CI time, as well as make it more palatable to use
zig build
for local testing. For example,zig build test-translate-c
in this branch took 0.8s for me vs 12s for master.Follow-Up Issues:
process.exit(1)
inmake()
implementations, instead set the stderr of step result. this way we don't end up with dead, useless threads.