Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig build: run steps in parallel #14647

Merged
merged 156 commits into from
Mar 16, 2023
Merged

zig build: run steps in parallel #14647

merged 156 commits into from
Mar 16, 2023

Conversation

andrewrk
Copy link
Member

@andrewrk andrewrk commented Feb 14, 2023

Finally, after this PR, when you run zig build, it will actually use all your cores to do stuff in parallel.

After fixing any issues that crop up in zig's own build script, this should reduce the CI time, as well as make it more palatable to use zig build for local testing. For example, zig build test-translate-c in this branch took 0.8s for me vs 12s for master.

Follow-Up Issues:

@andrewrk andrewrk added enhancement Solving this issue will likely involve adding new logic or components to the codebase. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. zig build system std.Build, the build runner, `zig build` subcommand, package management labels Feb 14, 2023
@andrewrk andrewrk force-pushed the build-parallel branch 2 times, most recently from 0589977 to f9ceb2b Compare February 21, 2023 17:32
@andrewrk andrewrk mentioned this pull request Feb 28, 2023
3 tasks
@andrewrk andrewrk force-pushed the build-parallel branch 7 times, most recently from 07a4545 to 6c14064 Compare March 7, 2023 07:51
@andrewrk andrewrk force-pushed the build-parallel branch 3 times, most recently from 4deabd3 to 0360628 Compare March 10, 2023 05:21
@andrewrk andrewrk force-pushed the build-parallel branch 2 times, most recently from 4d83076 to 1b8da32 Compare March 12, 2023 07:43
sterchelen added a commit to sterchelen/ziglings that referenced this pull request Mar 17, 2023
As part of ziglang/zig#14647 and more
specifically this zig commit
ziglang/zig@bf73620,
the color is now communicated via env vars.
sterchelen added a commit to sterchelen/ziglings that referenced this pull request Mar 17, 2023
As part of ziglang/zig#14647 and more
specifically this zig commit
ziglang/zig@bf73620,
the color is now communicated via env vars.

Signed-off-by: Nicolas Sterchele <[email protected]>
sterchelen added a commit to sterchelen/ziglings that referenced this pull request Mar 18, 2023
Step's Options introduced from the following PR
ziglang/zig#14647 and more precisely
this commit ziglang/zig@02381c0
sterchelen added a commit to sterchelen/ziglings that referenced this pull request Mar 18, 2023
Step's Options introduced from the following PR
ziglang/zig#14647 and more precisely
this commit ziglang/zig@02381c0

Also, MakeFn now takes a std.Progress.Node
introduces by ziglang/zig@0e07879
sterchelen added a commit to sterchelen/ziglings that referenced this pull request Mar 18, 2023
As part of ziglang/zig#14647 and more
specifically this zig commit
ziglang/zig@bf73620,
the color is now communicated via env vars.

Signed-off-by: Nicolas Sterchele <[email protected]>
sterchelen added a commit to sterchelen/ziglings that referenced this pull request Mar 18, 2023
Step's Options introduced from the following PR
ziglang/zig#14647 and more precisely
this commit ziglang/zig@02381c0

Also, MakeFn now takes a std.Progress.Node
introduces by ziglang/zig@0e07879
sterchelen added a commit to sterchelen/zig that referenced this pull request Mar 20, 2023
sterchelen added a commit to sterchelen/zig that referenced this pull request Mar 20, 2023
sterchelen added a commit to sterchelen/zig that referenced this pull request Apr 28, 2023
sterchelen added a commit to sterchelen/zig that referenced this pull request May 2, 2023
Vexu pushed a commit that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. enhancement Solving this issue will likely involve adding new logic or components to the codebase. zig build system std.Build, the build runner, `zig build` subcommand, package management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants