Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collect error return traces from errors other than error.MakeFailed #14961

Open
Tracked by #14647
andrewrk opened this issue Mar 17, 2023 · 0 comments · May be fixed by #15548
Open
Tracked by #14647

collect error return traces from errors other than error.MakeFailed #14961

andrewrk opened this issue Mar 17, 2023 · 0 comments · May be fixed by #15548
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. zig build system std.Build, the build runner, `zig build` subcommand, package management
Milestone
0.15.0

Comments

@andrewrk
Copy link
Member

Extracted from #14647.

zig/lib/std/Build/Step.zig

Lines 166 to 169 in b4d58e9

else => {
s.result_error_msgs.append(arena, @errorName(err)) catch @panic("OOM");
return error.MakeFailed;
},

Here it should capture an error return trace and include it as part of the result's error messages.
@andrewrk andrewrk added enhancement Solving this issue will likely involve adding new logic or components to the codebase. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. zig build system std.Build, the build runner, `zig build` subcommand, package management labels Mar 17, 2023
@andrewrk andrewrk added this to the 0.12.0 milestone Mar 17, 2023
@andrewrk andrewrk mentioned this issue Mar 17, 2023
Merged
52 tasks
@Parzival-3141 Parzival-3141 linked a pull request May 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. zig build system std.Build, the build runner, `zig build` subcommand, package management
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Build: Print return traces from BuildStep errors Parzival-3141/zig
1 participant
@andrewrk