Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce build_runner.phase enum {configure, make} and assert the phase in many functions #14941

Open
Tracked by #14647
andrewrk opened this issue Mar 16, 2023 · 0 comments
Open
Tracked by #14647

introduce build_runner.phase enum {configure, make} and assert the phase in many functions #14941

andrewrk opened this issue Mar 16, 2023 · 0 comments
Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. zig build system std.Build, the build runner, `zig build` subcommand, package management
Milestone
0.14.0

Comments

@andrewrk
Copy link
Member

Extracted from #14647.

I've seen quite a bit of build.zig code in the wild that does inappropriate things, such as call make() during build(), or create steps during make(). This issue is to set a global enum state to which phase is currently happening, and enforce that the API is only used in the intended phase.
@andrewrk andrewrk added breaking Implementing this issue could cause existing code to no longer compile or have different behavior. zig build system std.Build, the build runner, `zig build` subcommand, package management labels Mar 16, 2023
@andrewrk andrewrk added this to the 0.11.0 milestone Mar 16, 2023
@andrewrk andrewrk mentioned this issue Mar 16, 2023
Merged
52 tasks
@andrewrk andrewrk modified the milestones: 0.11.0, 0.12.0 Jul 22, 2023
@andrewrk andrewrk modified the milestones: 0.13.0, 0.12.0 Aug 5, 2023
@andrewrk andrewrk changed the title introduce build_runner.phase enum {declare, make} and assert the phase in many functions introduce build_runner.phase enum {configure, make} and assert the phase in many functions Aug 15, 2023
Closed
@andrewrk andrewrk modified the milestones: 0.12.0, 0.13.0 Feb 14, 2024
@andrewrk andrewrk mentioned this issue Aug 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. zig build system std.Build, the build runner, `zig build` subcommand, package management
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

std.Build: add {make, configure} phase field to Build der-teufel-programming/zig
1 participant
@andrewrk