Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from envoyproxy:main #38

Merged
merged 72 commits into from
Jan 13, 2024
Merged

[pull] main from envoyproxy:main #38

merged 72 commits into from
Jan 13, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 21, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

zirain and others added 11 commits December 19, 2023 14:23
* build(deps): bump the k8s-io group with 4 updates

Bumps the k8s-io group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver), [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) and [k8s.io/kubectl](https://github.com/kubernetes/kubectl).


Updates `k8s.io/api` from 0.28.4 to 0.29.0
- [Commits](kubernetes/api@v0.28.4...v0.29.0)

Updates `k8s.io/apiextensions-apiserver` from 0.28.3 to 0.29.0
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.28.3...v0.29.0)

Updates `k8s.io/cli-runtime` from 0.28.4 to 0.29.0
- [Commits](kubernetes/cli-runtime@v0.28.4...v0.29.0)

Updates `k8s.io/kubectl` from 0.28.4 to 0.29.0
- [Commits](kubernetes/kubectl@v0.28.4...v0.29.0)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-io
...

Signed-off-by: dependabot[bot] <[email protected]>

* gen

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: zirain <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* revert docs-preview action

Signed-off-by: zirain <[email protected]>

* pull_request

Signed-off-by: zirain <[email protected]>

* revert Welcome action

Signed-off-by: zirain <[email protected]>

* lint

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
* add route descriptor prefix for each xds route under listener

Signed-off-by: sh2 <[email protected]>

* simplify route and route rule descriptor keys and values

Signed-off-by: sh2 <[email protected]>

---------

Signed-off-by: sh2 <[email protected]>
Co-authored-by: Xunzhuo <[email protected]>
Co-authored-by: zirain <[email protected]>
* API: Support Circuit Breakers in BackendTrafficPolicy

Signed-off-by: Guy Daich <[email protected]>

* reivew fixes

Signed-off-by: Guy Daich <[email protected]>

* Implement API changes

Signed-off-by: Guy Daich <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
Co-authored-by: zirain <[email protected]>
* build(deps): bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add http3 support to EG

Signed-off-by: tanujd11 <[email protected]>

* addressed review comments

Signed-off-by: tanujd11 <[email protected]>

* address review comments: api changes

Signed-off-by: tanujd11 <[email protected]>

* address review comments: api changes

Signed-off-by: tanujd11 <[email protected]>

* addressed review comments

Signed-off-by: tanujd11 <[email protected]>

* rebase to main and make gen-check

Signed-off-by: tanujd11 <[email protected]>

* make gen-check

Signed-off-by: tanujd11 <[email protected]>

---------

Signed-off-by: tanujd11 <[email protected]>
* rm'd v1.26 for now, since we are only running last 3 versions

* k8s support matrix should be revisited pre GA

Signed-off-by: Arko Dasgupta <[email protected]>
* chore: add issue comment action

Signed-off-by: zirain <[email protected]>

* lint

Signed-off-by: zirain <[email protected]>

* update

Signed-off-by: zirain <[email protected]>

* lint

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
* API: Support FaultInjection in BackendTrafficPolicy

Signed-off-by: zhaonan <[email protected]>

* fix api and update cel

Signed-off-by: zhaonan <[email protected]>

* fix fault injection api

Signed-off-by: zhaonan <[email protected]>

---------

Signed-off-by: zhaonan <[email protected]>
* ci: add GITHUB default env

* fix: whitenoise lint failed when pull request

---------

Co-authored-by: Xunzhuo <[email protected]>
Copy link

🚀 Thank you for contributing to the Envoy Gateway project! 🚀

Before merging, please ensure to follow the process below:

  1. Requesting Reviews:
  • cc @envoyproxy/gateway-reviewers team for an initial review.
  • After the initial review, reviewers should request the @envoyproxy/gateway-maintainers team for further review.
  1. Review Approval:
  • Your PR needs to receive at least two approvals.
  • At least one approval must come from a member of the gateway-maintainers team.

NOTE: Once your PR is under review, please do not rebase and force push it. Otherwise, it will force your reviewers to review the PR from scratch rather than simply look at your latest changes.

What's more, you can help expedite the processing of your PR by
  • Ensuring you have self-reviewed your work according to the project's Contribution Guidelines.
  • If your PR addresses a specific issue, make sure to mention it in the PR description.
  • Respond promptly if there are any test failures or suggestions for improvements that we comment on.

@pull pull bot added the ⤵️ pull label Dec 21, 2023
Xunzhuo and others added 7 commits December 21, 2023 11:53
* local rate limit

Signed-off-by: huabing zhao <[email protected]>

* e2e test

Signed-off-by: huabing zhao <[email protected]>

* add default bucket for local rate limit

Signed-off-by: huabing zhao <[email protected]>

* set always_consume_default_token_bucket false

Signed-off-by: huabing zhao <[email protected]>

* set always_consume_default_token_bucket false

Signed-off-by: huabing zhao <[email protected]>

* address comments

Signed-off-by: huabing zhao <[email protected]>

* fix e2e test

Signed-off-by: huabing zhao <[email protected]>

* fix lint

Signed-off-by: huabing zhao <[email protected]>

* fix e2e test

Signed-off-by: huabing zhao <[email protected]>

* fix e2e test

Signed-off-by: huabing zhao <[email protected]>

* add comments to explain global rate limit rules

Signed-off-by: huabing zhao <[email protected]>

* fix gen

Signed-off-by: huabing zhao <[email protected]>

* add comments to explain local rate limit rules

Signed-off-by: huabing zhao <[email protected]>

* address comments

Signed-off-by: huabing zhao <[email protected]>

* fix gen

Signed-off-by: huabing zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
* support mergeGateways in EnvoyPatchPolicy

Signed-off-by: Karol Szwaj <[email protected]>

* validate GatewayClass as targetRef when mergeGateways is enabled

Signed-off-by: Karol Szwaj <[email protected]>

* gen-check

Signed-off-by: Karol Szwaj <[email protected]>

---------

Signed-off-by: Karol Szwaj <[email protected]>
Co-authored-by: zirain <[email protected]>
* Implement BTP CircuitBreaker API

Signed-off-by: Guy Daich <[email protected]>

* Fix testdate gen

Signed-off-by: Guy Daich <[email protected]>

* review fixes

Signed-off-by: Guy Daich <[email protected]>

* small fix, rebase

Signed-off-by: Guy Daich <[email protected]>

* gen fix

Signed-off-by: Guy Daich <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: huabing zhao <[email protected]>
* relax https for jwks

Signed-off-by: huabing zhao <[email protected]>

* address comments

Signed-off-by: huabing zhao <[email protected]>

* address comments

Signed-off-by: huabing zhao <[email protected]>

* address comments

Signed-off-by: huabing zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2023

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (6ec8afd) 64.48% compared to head (896d6a6) 64.73%.

Files Patch % Lines
internal/gatewayapi/backendtrafficpolicy.go 79.23% 65 Missing and 11 partials ⚠️
internal/gatewayapi/route.go 53.57% 22 Missing and 4 partials ⚠️
...frastructure/kubernetes/proxy/resource_provider.go 28.57% 9 Missing and 1 partial ⚠️
internal/infrastructure/kubernetes/infra.go 10.00% 9 Missing ⚠️
internal/gatewayapi/securitypolicy.go 86.53% 4 Missing and 3 partials ⚠️
internal/cmd/egctl/envoy_stats.go 0.00% 6 Missing ⚠️
internal/cmd/certgen.go 0.00% 4 Missing ⚠️
internal/infrastructure/kubernetes/infra_client.go 0.00% 2 Missing ⚠️
internal/cmd/egctl/version.go 0.00% 1 Missing ⚠️
internal/crypto/certgen.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   64.48%   64.73%   +0.25%     
==========================================
  Files         112      115       +3     
  Lines       15922    17402    +1480     
==========================================
+ Hits        10267    11266     +999     
- Misses       5007     5422     +415     
- Partials      648      714      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shahar-h and others added 9 commits December 23, 2023 10:11
Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.3.0 to 1.4.1.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](go-logr/logr@v1.3.0...v1.4.1)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.60.0 to 1.60.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.60.0...v1.60.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
…2356)

Bumps [envoyproxy/toolshed](https://github.com/envoyproxy/toolshed) from actions-v0.2.17 to 0.2.20. This release includes the previously tagged commit.
- [Release notes](https://github.com/envoyproxy/toolshed/releases)
- [Commits](envoyproxy/toolshed@actions-v0.2.17...actions-v0.2.20)

---
updated-dependencies:
- dependency-name: envoyproxy/toolshed
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2353)

Bumps google.golang.org/protobuf from 1.31.0 to 1.32.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 3.0.1 to 4.0.2.
- [Release notes](https://github.com/actions/deploy-pages/releases)
- [Commits](actions/deploy-pages@v3.0.1...v4.0.2)

---
updated-dependencies:
- dependency-name: actions/deploy-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
…2357)

Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 2.0.0 to 3.0.0.
- [Release notes](https://github.com/actions/upload-pages-artifact/releases)
- [Commits](actions/upload-pages-artifact@v2.0.0...v3.0.0)

---
updated-dependencies:
- dependency-name: actions/upload-pages-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Huabing Zhao <[email protected]>
* ci: fix retest command

Signed-off-by: zirain <[email protected]>

* Bump

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
Co-authored-by: Huabing Zhao <[email protected]>
mmorel-35 and others added 29 commits January 2, 2024 17:10
Signed-off-by: Matthieu MOREL <[email protected]>
* Setup Codeql workflow

Signed-off-by: Matthieu MOREL <[email protected]>

* clean unused default config

Signed-off-by: Matthieu MOREL <[email protected]>

---------

Signed-off-by: Matthieu MOREL <[email protected]>
…ub-actions/setup-deps (#2390)

build(deps): bump actions/setup-go in /tools/github-actions/setup-deps

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3.5.0 to 5.0.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@6edd440...0c52d54)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: support fault injection

Signed-off-by: zhaonan <[email protected]>

* fix lint

Signed-off-by: zhaonan <[email protected]>

* add unit test

Signed-off-by: zhaonan <[email protected]>

* fix lint

Signed-off-by: zhaonan <[email protected]>

* fix e2e

Signed-off-by: zhaonan <[email protected]>

---------

Signed-off-by: zhaonan <[email protected]>
use `strconv.ParseUint` instead of `strconv.Atoi` since
`Atoi` can lead to unexpected errors - if a string is parsed into an int,
and that int is converted into another integer type of a smaller size (uint32 in this case),
the result can produce unexpected values.

Signed-off-by: Arko Dasgupta <[email protected]>
Co-authored-by: zirain <[email protected]>
Add top level permissions for GHA workflows

Signed-off-by: Arko Dasgupta <[email protected]>
Pin Docker images versions

Signed-off-by: Matthieu MOREL <[email protected]>
defualted all base permissions to contents: read using
#2398
which broke the latest release action
https://github.com/envoyproxy/gateway/actions/runs/7415213672/job/20179669381

Signed-off-by: Arko Dasgupta <[email protected]>
* Add Health Check support to BackendTrafficPolicy

Signed-off-by: lemonlinger <[email protected]>

* use an array of int to represent expected http statuses

Signed-off-by: lemonlinger <[email protected]>

* fix cel validation tests

Signed-off-by: lemonlinger <[email protected]>

* deduplicate http statuses of the slice of ExpectedStatuses

Signed-off-by: lemonlinger <[email protected]>

* fix lint complaints

Signed-off-by: lemonlinger <[email protected]>

* inline health checker into health check config

Signed-off-by: lemonlinger <[email protected]>

* remove grpc health checker

Signed-off-by: lemonlinger <[email protected]>

* fix lint complaints

Signed-off-by: lemonlinger <[email protected]>

---------

Signed-off-by: lemonlinger <[email protected]>
support EndpointSlice with empty conditions `{}`

Signed-off-by: Zuo Zongyuan <[email protected]>
address github ci comments

Signed-off-by: Shawnh2 <[email protected]>
…2297)

* api: Add TLS configuration attributes in ClientTrafficPolicy

Signed-off-by: Lior Okman <[email protected]>

* Fixed typos in the comments.

Signed-off-by: Lior Okman <[email protected]>

* Updated the comment for `TLSSettings`.

Signed-off-by: Lior Okman <[email protected]>

* Regenerated after rebasing

Signed-off-by: Lior Okman <[email protected]>

* api: Add TLS configuration attributes in ClientTrafficPolicy

Signed-off-by: Lior Okman <[email protected]>

* feat: Implement setting common TLS parameters in ClientTrafficPolicy.
      Depends on #2287.

Signed-off-by: Lior Okman <[email protected]>

* Fixed linter and gen-check errors

Signed-off-by: Lior Okman <[email protected]>

* Implement the changes required after the reviewed API

Signed-off-by: Lior Okman <[email protected]>

* Set ALPN protocols in QUIC in the same way as in HTTPS

Signed-off-by: Lior Okman <[email protected]>

* * Regenerated and recreated the manifests after rebase
* Make the new tests pass

Signed-off-by: Lior Okman <[email protected]>

* Alphabetize the output test yamls to make "gen-check" pass

Signed-off-by: Lior Okman <[email protected]>

* * Remove references to the API from the XDS layer
* Use non API types in the IR structure
* Rename TLSListenerConfig to TLSConfig
* Use string slices instead of Enum slices for ALPN in the IR structure

Signed-off-by: Lior Okman <[email protected]>

* Changed the TLS protocol version constants to have a dot instead of an
underscore separator.

Signed-off-by: Lior Okman <[email protected]>

* * Reworked the ALPN logic so that an empty array in the IR layer
  translates to the required defaults in the XDS layer
* Fixed translation issues between the ALPN constants and the values
  required on the XDS level

Signed-off-by: Lior Okman <[email protected]>

* Make gen-check pass

Signed-off-by: Lior Okman <[email protected]>

* * Require that ALPN constants are also valid ALPN identification
  strings.
* Replace the user-facing "http/2" ALPN string with "h2".

Signed-off-by: Lior Okman <[email protected]>

---------

Signed-off-by: Lior Okman <[email protected]>
…specified if the minimal TLS version is 1.3 (#2424)

Added a CEL validation test for when the minimum TLS protocol is set to
version 1.3 and a cipher suite is specified.

Signed-off-by: Lior Okman <[email protected]>
* Implemented the Path Settings API

Signed-off-by: Lior Okman <[email protected]>

* Make all the rebased tests pass

Signed-off-by: Lior Okman <[email protected]>

---------

Signed-off-by: Lior Okman <[email protected]>
…2432)

* Support configuring externalTrafficPolicy on the envoy service

Signed-off-by: Tim Rice <[email protected]>

* Update some autogenerated things

Signed-off-by: Tim Rice <[email protected]>

---------

Signed-off-by: Tim Rice <[email protected]>
Co-authored-by: Tim Rice <[email protected]>
* add redirectURL and signoutPath to OIDC

Signed-off-by: huabing zhao <[email protected]>

* address comments

Signed-off-by: huabing zhao <[email protected]>

* change signoutpath to logoutpath

Signed-off-by: huabing zhao <[email protected]>

* fix check

Signed-off-by: huabing zhao <[email protected]>

* modify oidc docs

Signed-off-by: huabing zhao <[email protected]>

---------

Signed-off-by: huabing zhao <[email protected]>
Co-authored-by: zirain <[email protected]>
@pull pull bot merged commit 896d6a6 into zhaohuabing:main Jan 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.