Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix TLSSettings format #2428

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

ardikabs
Copy link
Contributor

What type of PR is this?

Before:
image

After:
image

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #2427

@ardikabs ardikabs requested a review from a team as a code owner January 10, 2024 06:41
Signed-off-by: Ardika Bagus <[email protected]>
@ardikabs ardikabs force-pushed the fix/tlssettings-format branch from 6f22995 to e586297 Compare January 10, 2024 07:07
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (316a0a2) 64.67% compared to head (e586297) 64.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2428      +/-   ##
==========================================
- Coverage   64.67%   64.66%   -0.02%     
==========================================
  Files         115      115              
  Lines       17326    17326              
==========================================
- Hits        11206    11204       -2     
- Misses       5409     5411       +2     
  Partials      711      711              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Contributor

zirain commented Jan 10, 2024

/retest

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shawnh2
Copy link
Contributor

shawnh2 commented Jan 10, 2024

/retest

1 similar comment
@ardikabs
Copy link
Contributor Author

/retest

@arkodg arkodg merged commit c9d5e33 into envoyproxy:main Jan 10, 2024
20 checks passed
@ardikabs ardikabs deleted the fix/tlssettings-format branch April 2, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: broken format displayed for TLSSettings reference
5 participants