Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: broken format displayed for TLSSettings reference #2427

Closed
ardikabs opened this issue Jan 10, 2024 · 1 comment · Fixed by #2428
Closed

docs: broken format displayed for TLSSettings reference #2427

ardikabs opened this issue Jan 10, 2024 · 1 comment · Fixed by #2428
Assignees
Labels

Comments

@ardikabs
Copy link
Contributor

Description:
See https://gateway.envoyproxy.io/latest/api/extension_types/#tlssettings

image

Repro steps:
Same with #2239, a new line breaks the format.

// Min specifies the minimal TLS protocol version to allow.
//
// The default is TLS 1.2 if this is not specified.
// +optional
MinVersion *TLSVersion `json:"minVersion,omitempty"`
// Max specifies the maximal TLS protocol version to allow
//
// The default is TLS 1.3 if this is not specified.
// +optional
MaxVersion *TLSVersion `json:"maxVersion,omitempty"`
// Ciphers specifies the set of cipher suites supported when
// negotiating TLS 1.0 - 1.2. This setting has no effect for TLS 1.3.
//
// In non-FIPS Envoy Proxy builds the default cipher list is:
// - [ECDHE-ECDSA-AES128-GCM-SHA256|ECDHE-ECDSA-CHACHA20-POLY1305]
// - [ECDHE-RSA-AES128-GCM-SHA256|ECDHE-RSA-CHACHA20-POLY1305]
// - ECDHE-ECDSA-AES256-GCM-SHA384
// - ECDHE-RSA-AES256-GCM-SHA384
//
// In builds using BoringSSL FIPS the default cipher list is:
// - ECDHE-ECDSA-AES128-GCM-SHA256
// - ECDHE-RSA-AES128-GCM-SHA256
// - ECDHE-ECDSA-AES256-GCM-SHA384
// - ECDHE-RSA-AES256-GCM-SHA384
//
// +optional
Ciphers []string `json:"ciphers,omitempty"`

Environment:
latest

Logs:

Include the access logs and the Envoy logs.

@ardikabs
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant