fix: Incorrect conversion between integer types #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `strconv.ParseUint` instead of `strconv.Atoi` since `Atoi` can lead to unexpected errors - if a string is parsed into an int, and that int is converted into another integer type of a smaller size (uint32 in this case), the result can produce unexpected values. Signed-off-by: Arko Dasgupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2397 +/- ##
==========================================
- Coverage 64.52% 64.50% -0.02%
==========================================
Files 115 115
Lines 16833 16833
==========================================
- Hits 10861 10858 -3
- Misses 5283 5286 +3
Partials 689 689 ☔ View full report in Codecov by Sentry. |
zirain
approved these changes
Jan 4, 2024
shawnh2
approved these changes
Jan 4, 2024
tmsnan
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
strconv.ParseUintinstead ofstrconv.AtoisinceAtoican lead to unexpected errors - if a string is parsed into an int, and that int is converted into another integer type of a smaller size (uint32 in this case), the result can produce unexpected values.