Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[KYUUBI apache#6006][HELM] Support additional labels for service monitor
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#6006 ## Describe Your Solution 🔧 Add new value `additionalLabels` in `serviceMonitor` to support templating the labels so that Prometheus can discover it ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Our Prometheus is based on `kube-prometheus-stack` chart, so it requires label `release: kube-prometheus-stack` The current setup of kyuubi helm does not allow the ServiceMonitor can be discovered by Prome because it's not able to pass extra labels to it. #### Behavior With This Pull Request 🎉 The MR enables templating extra labels #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6019 from sudohainguyen/helmchart. Closes apache#6006 69a86c5 [Hai Nguyen] chore: simplify labels values ed3fb0e [Hai Nguyen] [KYUUBI apache#6006] Support additional labels for service monitor Authored-by: Hai Nguyen <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
- Loading branch information