[KYUUBI #6006][HELM] Support additional labels for service monitor #6019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6019 +/- ##
============================================
- Coverage 61.19% 61.08% -0.12%
Complexity 23 23
============================================
Files 623 623
Lines 37060 37060
Branches 5024 5024
============================================
- Hits 22680 22639 -41
- Misses 11948 11980 +32
- Partials 2432 2441 +9 ☔ View full report in Codecov by Sentry. |
pan3793
reviewed
Jan 29, 2024
pan3793
reviewed
Jan 29, 2024
pan3793
approved these changes
Jan 29, 2024
pan3793
changed the title
|
Thanks, merged to master |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Feb 5, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#6006 ## Describe Your Solution 🔧 Add new value `additionalLabels` in `serviceMonitor` to support templating the labels so that Prometheus can discover it ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Our Prometheus is based on `kube-prometheus-stack` chart, so it requires label `release: kube-prometheus-stack` The current setup of kyuubi helm does not allow the ServiceMonitor can be discovered by Prome because it's not able to pass extra labels to it. #### Behavior With This Pull Request 🎉 The MR enables templating extra labels #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6019 from sudohainguyen/helmchart. Closes apache#6006 69a86c5 [Hai Nguyen] chore: simplify labels values ed3fb0e [Hai Nguyen] [KYUUBI apache#6006] Support additional labels for service monitor Authored-by: Hai Nguyen <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#6006 ## Describe Your Solution 🔧 Add new value `additionalLabels` in `serviceMonitor` to support templating the labels so that Prometheus can discover it ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Our Prometheus is based on `kube-prometheus-stack` chart, so it requires label `release: kube-prometheus-stack` The current setup of kyuubi helm does not allow the ServiceMonitor can be discovered by Prome because it's not able to pass extra labels to it. #### Behavior With This Pull Request 🎉 The MR enables templating extra labels #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6019 from sudohainguyen/helmchart. Closes apache#6006 69a86c5 [Hai Nguyen] chore: simplify labels values ed3fb0e [Hai Nguyen] [KYUUBI apache#6006] Support additional labels for service monitor Authored-by: Hai Nguyen <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #6006
Describe Your Solution 🔧
Add new value
additionalLabelsinserviceMonitorto support templating the labels so that Prometheus can discover itTypes of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Our Prometheus is based on
kube-prometheus-stackchart, so it requires labelrelease: kube-prometheus-stackThe current setup of kyuubi helm does not allow the ServiceMonitor can be discovered by Prome because it's not able to pass extra labels to it.
Behavior With This Pull Request 🎉
The MR enables templating extra labels
Related Unit Tests
Checklist 📝
Be nice. Be informative.