[Improvement] Add template to provide additional labels for ServiceMonitor #6006
Closed
3 of 4 tasks
Comments
|
Hello @sudohainguyen, |
sudohainguyen
changed the title
sudohainguyen
added a commit
to sudohainguyen/kyuubi
that referenced
this issue
Jan 25, 2024
4 tasks
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this issue
Feb 5, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#6006 ## Describe Your Solution 🔧 Add new value `additionalLabels` in `serviceMonitor` to support templating the labels so that Prometheus can discover it ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Our Prometheus is based on `kube-prometheus-stack` chart, so it requires label `release: kube-prometheus-stack` The current setup of kyuubi helm does not allow the ServiceMonitor can be discovered by Prome because it's not able to pass extra labels to it. #### Behavior With This Pull Request 🎉 The MR enables templating extra labels #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6019 from sudohainguyen/helmchart. Closes apache#6006 69a86c5 [Hai Nguyen] chore: simplify labels values ed3fb0e [Hai Nguyen] [KYUUBI apache#6006] Support additional labels for service monitor Authored-by: Hai Nguyen <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this issue
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes apache#6006 ## Describe Your Solution 🔧 Add new value `additionalLabels` in `serviceMonitor` to support templating the labels so that Prometheus can discover it ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ Our Prometheus is based on `kube-prometheus-stack` chart, so it requires label `release: kube-prometheus-stack` The current setup of kyuubi helm does not allow the ServiceMonitor can be discovered by Prome because it's not able to pass extra labels to it. #### Behavior With This Pull Request 🎉 The MR enables templating extra labels #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6019 from sudohainguyen/helmchart. Closes apache#6006 69a86c5 [Hai Nguyen] chore: simplify labels values ed3fb0e [Hai Nguyen] [KYUUBI apache#6006] Support additional labels for service monitor Authored-by: Hai Nguyen <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
What would you like to be improved?
extend the current servicemonitor template to add extra labels
How should we improve?
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: