xtensa: fix inline assembly of rsil in exception code for XCC #56790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compilation still fails with the same error message as shared in |
dcpleung
force-pushed
the
xtensa/exc_xcc
branch
from
24bd23d to
5175531
Compare
|
Can you try the latest one? I removed the last colon of the line. |
|
5175531 fixes the compilation issue with |
|
Can you please add a |
Commit 4084726 added inline assembly to lock interrupt. However, XCC doesn't like the syntax using STRINGIFY, and also an empty clobber section. So parameterize the second argument to rsil, and remove the last colon. Signed-off-by: Daniel Leung <[email protected]>
dcpleung
force-pushed
the
xtensa/exc_xcc
branch
from
5175531 to
7faed58
Compare
marc-hb
added
bug
marc-hb
requested review from
aasthagr,
peter-mitsis,
dbaluta,
aborisovich,
abonislawski,
kv2019i and
tmleman
tmleman
approved these changes
Apr 17, 2023
kv2019i
approved these changes
Apr 20, 2023
dbaluta
approved these changes
Apr 20, 2023
nashif
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XCC doesn't like the syntax using STRINGIFY. So parameterize the second argument to rsil.