Bluetooth: Controller: Implement Periodic Advertiser List #38338

cvinayak · 2021-09-06T11:06:33Z

Implement support for Periodic Advertiser List to be used
in LE Periodic Advertising Create Sync command.

Fixes #38316.

Signed-off-by: Vinayak Kariappa Chettimada [email protected]

subsys/bluetooth/controller/Kconfig

subsys/bluetooth/controller/ll_sw/lll_filter.h

subsys/bluetooth/controller/ll_sw/ull_filter.c

subsys/bluetooth/controller/ll_sw/ull_scan_aux.c

saleh-unikie · 2021-09-14T13:14:17Z

subsys/bluetooth/controller/Kconfig

@@ -497,6 +497,22 @@ config BT_CTLR_SYNC_PERIODIC
 config BT_CTLR_SYNC_PERIODIC
 	bool "LE Periodic Advertising in Synchronization State [EXPERIMENTAL]" if BT_LL_SW_SPLIT

+config BT_CTLR_SYNC_PERIODIC_ADV_LIST


Is it possible to use this parameter option "BT_LE_PER_ADV_SYNC_OPT_USE_PER_ADV_LIST" (defined at bluetooth.h) automatically instead of defining a new kconfig? or at least generating a warning when this option is used but this config is not set.

No, that is an API parameter, and this is a Controller feature.

saleh-unikie · 2021-09-14T13:27:27Z

subsys/bluetooth/controller/Kconfig

+	help
+	  Enable support for LE Periodic Advertiser List support.
+
+config BT_CTLR_SYNC_PERIODIC_ADV_LIST_SIZE


Isn't this config a redundant to the "CONFIG_BT_PER_ADV_SYNC_MAX"?

No, maximum supported simultaneous synchronizations can be lower than listed number of advertisers; only one advertiser is synchronized for every LE Periodic Advertising Create Sync Command, and Memory Capacity Exceeded error is used to convey insufficient resources to handle any more periodic advertising trains.

Got it! so setting the "CONFIG_BT_PER_ADV_SYNC_MAX" to a number greater than the "BT_CTLR_SYNC_PERIODIC_ADV_LIST_SIZE" is useless, right?

Maximum simultaneous synchronizations CONFIG_BT_PER_ADV_SYNC_MAX can be greater than, says number of trusted peer device stored in a list CONFIG_BT_CTLR_SYNC_PERIODIC_ADV_LIST_SIZE. List is just a convenience, to be able to synchronize to any of the listed peers on a first-seen basis. Applications are permitted to use explicit peer device address to create additional synchronizations beyond the number of entries that be accommodated in the Periodic Advertiser List.

cvinayak · 2021-09-14T15:56:37Z

@carlescufi Request your attention to this commit 4bc5d45 in this PR which partly handles inclusive naming related to filter implementation in the Controller. Your review is welcome here in this PR until the commit is ready to be cherry-picked out of this PR (so that other commits in this PR will have reduced rework effort)

cvinayak · 2021-09-22T17:28:59Z

subsys/bluetooth/controller/Kconfig

@@ -391,7 +391,7 @@ config BT_CTLR_FAL_SIZE
 	range 1 8  if  (SOC_COMPATIBLE_NRF || SOC_OPENISA_RV32M1_RISCV32)
 	range 1 16 if !(SOC_COMPATIBLE_NRF || SOC_OPENISA_RV32M1_RISCV32)
 	help
-	  Set the size of the White List for LE Controller-based Privacy.


@carlescufi Do you want to send a separate PR for this being missed upstream?

subsys/bluetooth/controller/hci/hci.c

subsys/bluetooth/controller/include/ll.h

subsys/bluetooth/controller/ll_sw/lll_filter.h

Thalley · 2021-09-22T19:57:01Z

@cvinayak I feel like this PR is becoming a catch-all for several issue (updates to filter accept list and addition of const), and that kind of distracts from what the PR should be doing.

Since I've already reviewed it, it's okay for me to keep as is, but probably beneficial for others if those changes were split to 3 PRs.

Refactoring related to filter accept list, resolving list, and removed the redundant anon variable. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Refactor `ull_filter_adva_get` and `ull_filter_adva_get` to input resolving index compare to adv context reference. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Implement support for Periodic Advertiser List to be used in LE Periodic Advertising Create Sync command. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Refactor out the implementation of Periodic Sync Setup address check including Periodic Advertiser List and SID. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Updated the bsim_bt_advx test with use of periodic advertiser list. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

ppryga-nordic

Few minor things.

I'm not a fan of abbreviations like pal for periodic advertising list. It is hard to figure out what is it until you are in the topic.

subsys/bluetooth/controller/hci/hci.c

subsys/bluetooth/controller/ll_sw/lll_filter.h

subsys/bluetooth/controller/ll_sw/ull_filter.c

github-actions bot added area: Bluetooth area: Bluetooth Controller labels Sep 6, 2021

cvinayak force-pushed the github_per_adv_list branch 2 times, most recently from 4e84b43 to 5c5ad62 Compare September 6, 2021 11:45

cvinayak self-assigned this Sep 6, 2021

cvinayak force-pushed the github_per_adv_list branch 4 times, most recently from 23026f4 to 1e73123 Compare September 6, 2021 15:23

cvinayak mentioned this pull request Sep 7, 2021

Synchronize multiple DF TX devices in the DF Connectionless RX Example "Periodic Advertising list" #38316

Closed

cvinayak force-pushed the github_per_adv_list branch 4 times, most recently from 9c21101 to 83e7b8b Compare September 9, 2021 09:48

cvinayak requested review from ppryga-nordic and Thalley September 9, 2021 13:33

cvinayak marked this pull request as ready for review September 9, 2021 13:36

cvinayak requested review from carlescufi, kruithofa and thoh-ot as code owners September 9, 2021 13:36

Thalley requested changes Sep 9, 2021

View reviewed changes

cvinayak force-pushed the github_per_adv_list branch 4 times, most recently from f77e105 to f4b3b59 Compare September 10, 2021 09:08

cvinayak requested review from jhedberg, joerchan and Vudentz as code owners September 10, 2021 09:08

github-actions bot added the area: Tests Issues related to a particular existing or missing test label Sep 10, 2021

cvinayak force-pushed the github_per_adv_list branch from f4b3b59 to 71f6659 Compare September 10, 2021 09:58

saleh-unikie reviewed Sep 14, 2021

View reviewed changes

cvinayak force-pushed the github_per_adv_list branch from e6c9190 to 7f3d9ad Compare September 14, 2021 15:20

cvinayak requested a review from Thalley September 14, 2021 16:39

cvinayak added the area: Bluetooth Qualification Bluetooth Qualification -related issues and pull requests label Sep 15, 2021

carlescufi added this to the v2.7.0 milestone Sep 16, 2021

cvinayak mentioned this pull request Sep 16, 2021

Bluetooth: Host: Fix Periodic Advertising Sync using Advertiser Lists #38594

Merged

cvinayak force-pushed the github_per_adv_list branch from 7f3d9ad to a84cc5f Compare September 22, 2021 17:19

cvinayak requested review from aescolar and wopu-ot as code owners September 22, 2021 17:19

cvinayak force-pushed the github_per_adv_list branch from a84cc5f to e72f0c7 Compare September 22, 2021 17:23

cvinayak commented Sep 22, 2021

View reviewed changes

Thalley reviewed Sep 22, 2021

View reviewed changes

subsys/bluetooth/controller/hci/hci.c Outdated Show resolved Hide resolved

subsys/bluetooth/controller/include/ll.h Outdated Show resolved Hide resolved

subsys/bluetooth/controller/ll_sw/lll_filter.h Outdated Show resolved Hide resolved

cvinayak force-pushed the github_per_adv_list branch from e72f0c7 to 89119ec Compare September 28, 2021 04:10

cvinayak added 5 commits September 28, 2021 09:56

Bluetooth: Controller: Minor filter accept list related refactoring

b9a76b0

Refactoring related to filter accept list, resolving list, and removed the redundant anon variable. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Bluetooth: Controller: Refactor ull_filter adva_get and tgta_get

1c7645c

Refactor `ull_filter_adva_get` and `ull_filter_adva_get` to input resolving index compare to adv context reference. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Bluetooth: Controller: Implement Periodic Advertiser List

64d80d1

Implement support for Periodic Advertiser List to be used in LE Periodic Advertising Create Sync command. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

Bluetooth: Controller: Refactor out sync setup addr and sid check

75620f6

Refactor out the implementation of Periodic Sync Setup address check including Periodic Advertiser List and SID. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

tests: Bluetooth: bsim: Updated advx tests with periodic adv list

7162eae

Updated the bsim_bt_advx test with use of periodic advertiser list. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>

cvinayak force-pushed the github_per_adv_list branch from 89119ec to 7162eae Compare September 28, 2021 04:58

Thalley approved these changes Sep 28, 2021

View reviewed changes

ppryga-nordic requested changes Sep 30, 2021

View reviewed changes

carlescufi removed this from the v2.7.0 milestone Sep 30, 2021

cvinayak mentioned this pull request Oct 1, 2021

Bluetooth: Periodic Advertising, Filter Accept List, Resolving list related variable name abbreviations #39025

Closed

cvinayak requested a review from ppryga-nordic October 1, 2021 12:28

ppryga-nordic approved these changes Oct 1, 2021

View reviewed changes

carlescufi merged commit ac1e99f into zephyrproject-rtos:main Oct 1, 2021

ppryga-nordic mentioned this pull request Oct 2, 2021

[Fix for qualification tests] - Bluetooth: controller: Add filtering of periodic advertising sync. by CTE type #38292

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bluetooth: Controller: Implement Periodic Advertiser List #38338

Bluetooth: Controller: Implement Periodic Advertiser List #38338

cvinayak commented Sep 6, 2021 •

edited

Loading

saleh-unikie Sep 14, 2021 •

edited

Loading

cvinayak Sep 14, 2021

saleh-unikie Sep 14, 2021

cvinayak Sep 14, 2021

saleh-unikie Sep 14, 2021

cvinayak Sep 14, 2021

cvinayak commented Sep 14, 2021

cvinayak Sep 22, 2021

Thalley commented Sep 22, 2021

ppryga-nordic left a comment

Bluetooth: Controller: Implement Periodic Advertiser List #38338

Bluetooth: Controller: Implement Periodic Advertiser List #38338

Conversation

cvinayak commented Sep 6, 2021 • edited Loading

saleh-unikie Sep 14, 2021 • edited Loading

Choose a reason for hiding this comment

cvinayak Sep 14, 2021

Choose a reason for hiding this comment

saleh-unikie Sep 14, 2021

Choose a reason for hiding this comment

cvinayak Sep 14, 2021

Choose a reason for hiding this comment

saleh-unikie Sep 14, 2021

Choose a reason for hiding this comment

cvinayak Sep 14, 2021

Choose a reason for hiding this comment

cvinayak commented Sep 14, 2021

cvinayak Sep 22, 2021

Choose a reason for hiding this comment

Thalley commented Sep 22, 2021

ppryga-nordic left a comment

Choose a reason for hiding this comment

cvinayak commented Sep 6, 2021 •

edited

Loading

saleh-unikie Sep 14, 2021 •

edited

Loading