Bluetooth: Host: Fix Periodic Advertising Sync using Advertiser Lists #38594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinayak
requested review from
jhedberg,
joerchan and
Vudentz
as code owners
cvinayak
force-pushed
the
github_per_adv_list_fix
branch
from
cfe9de5 to
c45ec77
Compare
|
@saleh-unikie please check if this PR in combination with #38338 fixes #38520 |
Yes, Thank you! |
Thalley
requested changes
Sep 16, 2021
subsys/bluetooth/host/scan.c
Outdated
Comment on lines
697
to
700
| (!atomic_test_bit(pending_per_adv_sync->flags, | ||
| BT_PER_ADV_SYNC_USE_LIST) && | ||
| ((pending_per_adv_sync->sid != evt->sid) || | ||
| bt_addr_le_cmp(&pending_per_adv_sync->addr, &evt->adv_addr)))) { |
There was a problem hiding this comment.
The check here is correct, although I wish we could make it a bit more readable, but I don't have any suggestions.
There's a little bit of indentation that should be fixed
Suggested change
| (!atomic_test_bit(pending_per_adv_sync->flags, | |
| BT_PER_ADV_SYNC_USE_LIST) && | |
| ((pending_per_adv_sync->sid != evt->sid) || | |
| bt_addr_le_cmp(&pending_per_adv_sync->addr, &evt->adv_addr)))) { | |
| (!atomic_test_bit(pending_per_adv_sync->flags, | |
| BT_PER_ADV_SYNC_USE_LIST) && | |
| ((pending_per_adv_sync->sid != evt->sid) || | |
| bt_addr_le_cmp(&pending_per_adv_sync->addr, &evt->adv_addr)))) { |
There was a problem hiding this comment.
Only line 698 was missing a whitespace, fixed.
subsys/bluetooth/host/hci_core.h
Outdated
Comment on lines
159
to
161
| /** Periodic Advertising Sync Create using Advertiser List */ | ||
| BT_PER_ADV_SYNC_USE_LIST, | ||
|
|
There was a problem hiding this comment.
Suggested change
| /** Periodic Advertising Sync Create using Advertiser List */ | |
| BT_PER_ADV_SYNC_USE_LIST, | |
| /** Periodic advertising is attempting sync sync */ using Advertiser List */ | |
| BT_PER_ADV_SYNC_SYNCING_USE_LIST, |
And move next to the BT_PER_ADV_SYNC_SYNCING flag as those are the most related flags.
There was a problem hiding this comment.
Update this and other comments.
Fix Periodic Advertising Sync Establishment to accept synchronization establishment to device listed in the Periodic Advertisers List when filter policy was used. Fixes zephyrproject-rtos#38520. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_per_adv_list_fix
branch
from
c45ec77 to
3335631
Compare
Thalley
approved these changes
Sep 16, 2021
carlescufi
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Periodic Advertising Sync Establishment to accept
synchronization establishment to device listed in the
Periodic Advertisers List when filter policy was used.
Fixes #38520.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]