-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Controller: Implement Periodic Advertiser List #38338
Changes from all commits
b9a76b0
1c7645c
64d80d1
75620f6
7162eae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -391,7 +391,7 @@ config BT_CTLR_FAL_SIZE | |
range 1 8 if (SOC_COMPATIBLE_NRF || SOC_OPENISA_RV32M1_RISCV32) | ||
range 1 16 if !(SOC_COMPATIBLE_NRF || SOC_OPENISA_RV32M1_RISCV32) | ||
help | ||
Set the size of the White List for LE Controller-based Privacy. | ||
Set the size of the Filter Accept List for LE Controller-based Privacy. | ||
On nRF5x-based controllers, the hardware imposes a limit of 8 devices. | ||
On OpenISA-based controllers, the hardware imposes a limit of 8 devices. | ||
|
||
|
@@ -497,6 +497,22 @@ config BT_CTLR_SYNC_PERIODIC | |
config BT_CTLR_SYNC_PERIODIC | ||
bool "LE Periodic Advertising in Synchronization State [EXPERIMENTAL]" if BT_LL_SW_SPLIT | ||
|
||
config BT_CTLR_SYNC_PERIODIC_ADV_LIST | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it possible to use this parameter option "BT_LE_PER_ADV_SYNC_OPT_USE_PER_ADV_LIST" (defined at bluetooth.h) automatically instead of defining a new kconfig? or at least generating a warning when this option is used but this config is not set. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, that is an API parameter, and this is a Controller feature. |
||
bool "LE Periodic Advertiser List support" | ||
depends on BT_CTLR_SYNC_PERIODIC | ||
default y | ||
help | ||
Enable support for LE Periodic Advertiser List support. | ||
|
||
config BT_CTLR_SYNC_PERIODIC_ADV_LIST_SIZE | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't this config a redundant to the "CONFIG_BT_PER_ADV_SYNC_MAX"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, maximum supported simultaneous synchronizations can be lower than listed number of advertisers; only one advertiser is synchronized for every LE Periodic Advertising Create Sync Command, and Memory Capacity Exceeded error is used to convey insufficient resources to handle any more periodic advertising trains. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got it! so setting the "CONFIG_BT_PER_ADV_SYNC_MAX" to a number greater than the "BT_CTLR_SYNC_PERIODIC_ADV_LIST_SIZE" is useless, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maximum simultaneous synchronizations |
||
int "LE Periodic Advertiser List size" | ||
depends on BT_CTLR_SYNC_PERIODIC_ADV_LIST | ||
range 1 255 | ||
default 8 | ||
help | ||
Set Periodic Advertiser List size, this will be return in the HCI LE | ||
Read Periodic Advertiser List Command. | ||
|
||
config BT_CTLR_ADV_ISO | ||
bool "LE Broadcast Isochronous Channel advertising" if !BT_LL_SW_SPLIT | ||
depends on BT_BROADCASTER && BT_CTLR_ADV_ISO_SUPPORT | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlescufi Do you want to send a separate PR for this being missed upstream?