device: revert device dependency injection #31548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fd5fa20. Signed-off-by: Peter Bigot <[email protected]>
This reverts commit a3af137. Signed-off-by: Peter Bigot <[email protected]>
This reverts commit 58b035a. Signed-off-by: Peter Bigot <[email protected]>
This reverts commit 40d3653. Signed-off-by: Peter Bigot <[email protected]>
…nodes" This reverts commit b615153. Signed-off-by: Peter Bigot <[email protected]>
pabigot
requested review from
andrewboie,
andyross,
jakub-uC,
nashif,
nordic-krch,
tejlmand and
wentongwu
as code owners
github-actions
bot
added
area: API
andrewboie
approved these changes
Jan 22, 2021
|
@andrewboie I've rebased your #30907 and it seems to fix the problem. I can add those to this PR, but would rather let you verify and push again. Sorry for the trouble. |
This was referenced Jan 22, 2021
nashif
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31546 identifies that the second phase link with replacement handle arrays results in the arrays being re-ordered and padding to change in at least one example (#31528) which causes symbol offsets to change. Revert this feature until an alternative solution can be found.
Fixes #31546