device: fix mishandling of null device handle #31541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent was always to have a zero valued device handle represent an unknown device. This was not reflected in the values used for handles, which were instead the zero-based ordinal of the device within the device table, making the first device indistinguishable from the null device. Fix the generated dependency handles and the round-trip conversions between handle and device pointer. Signed-off-by: Peter Bigot <[email protected]>
A null device should map to a null device handle. Signed-off-by: Peter Bigot <[email protected]>
A null device name should map to a null device. Signed-off-by: Peter Bigot <[email protected]>
pabigot
requested review from
andrewboie,
andyross,
nashif and
wentongwu
as code owners
galak
approved these changes
Jan 22, 2021
|
Moved to draft as the device handle solution will be reverted by #31548. |
|
This will be incorporated into the PR that updates the device dependency infrastructure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent was always to have a zero valued device handle represent an unknown device. This was not reflected in the values used for handles, which were instead the zero-based ordinal of the device within the device table, making the first device indistinguishable from the null device.
Fix the generated dependency handles and the round-trip conversions between handle and device pointer.
Incidentally fixes the same issue as #31526, which this supersedes.