device: fix potential truncation of DT-derived device names #31556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabigot
added
Blocked
pabigot
requested review from
andrewboie,
andyross,
jakub-uC,
mbolivar-nordic,
nordic-krch,
tejlmand and
wentongwu
as code owners
github-actions
bot
added
area: API
pabigot
force-pushed
the
nordic/20210123a
branch
from
2fa9521 to
33f8fee
Compare
pabigot
force-pushed
the
nordic/20210123a
branch
from
33f8fee to
ab68d2e
Compare
While using the encoded path to a device tree node guarantees a unique identifier for the corresponding device there is a limit on the number of characters of that name that can be captured when looking up a device by name from user mode, and the path can exceed that limit. Synthesize a unique name from the node dependency ordinal instead, and update the gen_defines script to record the name associated with the full path in the extern declaration. Add a build-time check that no device is created with a name that violates the user mode requirement. Also update the network device DTS helper functions to use the same inference for dev_name and label that the real one does, since they bypass the real one. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
nordic/20210123a
branch
from
ab68d2e to
ba3d6f4
Compare
pabigot
removed
Blocked
pabigot
removed request for
jukkar,
andrewboie,
tejlmand,
nordic-krch,
jakub-uC and
wentongwu
mbolivar-nordic
approved these changes
Jan 25, 2021
nashif
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the encoded path to a device tree node guarantees a unique identifier for the corresponding device there is a limit on the number of characters of that name that can be captured when looking up a device by name from user mode, and the path can exceed that limit.
Synthesize a unique name from the node dependency ordinal instead, and update the gen_defines script to record the name associated with the full path in the extern declaration.
Add a build-time check that no device is created with a name that violates the user mode requirement.
Also update the ethernet device DTS helper function to use the same inference for dev_name and label that the real one does, since it bypasses the real one.