chore(accordion): refactor storybook #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
commented
Feb 22, 2022
|
|
||
| ### useAccordion | ||
|
|
||
| The `useAccordion` hook manages toggle state and required accessibility | ||
| attributes for a group of sections. | ||
|
|
||
| ```jsx static |
There was a problem hiding this comment.
These tags are leftover from styleguidist usage and prevent proper codeblock display in storybook.
jzempel
commented
Feb 22, 2022
| </Story> | ||
| </Canvas> | ||
|
|
||
| ## Controlled |
There was a problem hiding this comment.
Where applicable, stories will be enhanced during refactor to demonstrate both controlled and uncontrolled usage.
jzempel
commented
Feb 22, 2022
| tabIndex: null, | ||
| disabled | ||
| })} | ||
| className="text-left w-full" |
There was a problem hiding this comment.
Beginning to leverage tailwind 😉
jzempel
changed the title
4 tasks
hzhu
approved these changes
Feb 22, 2022
This was referenced Feb 24, 2022
This was referenced Mar 3, 2022
This was referenced Mar 8, 2022
4 tasks
This was referenced Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-on from #418 and begins to bring this repo in line with zendeskgarden/react-components#1265. This PR is limited to the
accordionpackage and also brings the.templateup to date with the refactor. Subsequent PRs will follow to replace individual package*.stories.tsxfiles with the updated MDX demo structure.Checklist
yarn start)analyzed via axe and evaluated using VoiceOverincludes new unit teststested in Chrome, Firefox, Safari, Edge, and IE11