chore(schedule): refactor storybook #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomcal
reviewed
Mar 8, 2022
|
|
||
| const Container = ({ loop, ...props }: IScheduleContainerProps) => ( | ||
| <ScheduleContainer loop={loop} {...props}> | ||
| {containerProps => <Component {...containerProps} loop={loop} />} |
There was a problem hiding this comment.
Wouldn't containerProps also pass thru loop from the container with no need to manually pass loop to Component?
There was a problem hiding this comment.
Unfortunately, the loop prop is not reconstituted in the containerProps. (In going through this exercise, I'm noting API discontinuity between the packages – this is one area where we could improve consistency.) So, I'm feeding it through. But worth noting that a) it is simply for string display, and b) these particular (overly) abstracted examples are a bit contrived since IRL one would either use the container or the hook and all the props would likely be available in one place.
mtomcal
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #420, update storybook for the
schedulepackage.Checklist
yarn start)includes new unit teststested in Chrome, Firefox, Safari, Edge, and IE11