chore(scrollregion): refactor storybook #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomcal
reviewed
Mar 8, 2022
| props.tabIndex === 0 ? 'border-blue-600' : 'border-grey-300' | ||
| )} | ||
| style={{ height, width }} | ||
| ref={ref as RefObject<HTMLDivElement>} |
There was a problem hiding this comment.
Just out of curiosity, why do we do forwardRef<HTMLElement, X> versus forwardRef<HTMLDivElement, X> and cast to a RefObject<HTMLDivElement> here?
There was a problem hiding this comment.
Yeah, this has a bad code smell. And it goes all the way back to the container API. I've updated the container interfaces with generics that take HTMLElement as a default, but can be overridden in order to specify the containerRef type (which, in the case of this story should be HTMLDivElement).
We should get better at using generics throughout Garden. 😉
mtomcal
approved these changes
Mar 8, 2022
hzhu
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #420, update storybook for the
scrollregionpackage.Checklist
yarn start)analyzed via axe and evaluated using VoiceOverincludes new unit teststested in Chrome, Firefox, Safari, Edge, and IE11