Revert terminal: Add Alt key bindings for terminal #15535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
This was referenced Jul 31, 2024
notpeter
changed the title
1 task
notpeter
added a commit
that referenced
this pull request
Oct 17, 2024
- This reverts the change I made in #15535 which set `option_as_meta` to `true` in the default settings. - `true` is a reasonable default for US Keyboards, but is terrible for many others which rely on `alt+<key>` for totally normal keystroke combinations.
noaccOS
pushed a commit
to noaccOS/zed
that referenced
this pull request
Oct 19, 2024
…s#19364) - This reverts the change I made in zed-industries#15535 which set `option_as_meta` to `true` in the default settings. - `true` is a reasonable default for US Keyboards, but is terrible for many others which rely on `alt+<key>` for totally normal keystroke combinations.
osiewicz
pushed a commit
that referenced
this pull request
Oct 22, 2024
- This reverts the change I made in #15535 which set `option_as_meta` to `true` in the default settings. - `true` is a reasonable default for US Keyboards, but is terrible for many others which rely on `alt+<key>` for totally normal keystroke combinations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option_as_metato trueThis reverts #14556 which was to address #14543.
I thought emacs (meta) keybindings were broken by default.
But it turns out
option_as_metawas just disabled by default.Oops
The option-as-meta docs didn't match the code.
Changing the default to true means various command line tools (emacs, less, readline) support their full keybinds out-of-the-box in terminal.
Release Notes: