Make terminal.option_as_meta=false in default settings #19364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
notpeter
pushed a commit
that referenced
this pull request
Oct 17, 2024
This PR is a quick follow-up to #19364 which updates some left-out occurrences of `option_as_meta` to the new default value (`false`).
noaccOS
pushed a commit
to noaccOS/zed
that referenced
this pull request
Oct 19, 2024
…s#19364) - This reverts the change I made in zed-industries#15535 which set `option_as_meta` to `true` in the default settings. - `true` is a reasonable default for US Keyboards, but is terrible for many others which rely on `alt+<key>` for totally normal keystroke combinations.
noaccOS
pushed a commit
to noaccOS/zed
that referenced
this pull request
Oct 19, 2024
…industries#19369) This PR is a quick follow-up to zed-industries#19364 which updates some left-out occurrences of `option_as_meta` to the new default value (`false`).
osiewicz
pushed a commit
that referenced
this pull request
Oct 22, 2024
- This reverts the change I made in #15535 which set `option_as_meta` to `true` in the default settings. - `true` is a reasonable default for US Keyboards, but is terrible for many others which rely on `alt+<key>` for totally normal keystroke combinations.
osiewicz
pushed a commit
that referenced
this pull request
Oct 22, 2024
This PR is a quick follow-up to #19364 which updates some left-out occurrences of `option_as_meta` to the new default value (`false`).
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the change I made in #15535 which set
option_as_metatotruein the default settings.trueis a reasonable default for US Keyboards, but is terrible for many others which rely onalt+<key>for totally normal keystroke combinations.Our intention is to support individual mapping of left_alt / right_alt actions (e.g. meta / alt) as part of the work discussed here:
Release Notes:
terminal.option_as_metadefault fromtruetofalsefor better out-of-the-box experience on non-US keyboards. Terminal Emacs users will want to set this totrue.