Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal: Add Alt key bindings for terminal #14556

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

CharlesChen0823
Copy link
Contributor

@CharlesChen0823 CharlesChen0823 commented Jul 16, 2024

Release Notes:

  • Improve Terminal compatibility with emacs-style meta (alt/option) shortcuts. (#14543, thanks @CharlesChen0823)

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 16, 2024
@notpeter
Copy link
Member

@CharlesChen0823 Thank you for doing this and apologies for the delayed review.

I noticed that emacs query replace (M-%) was also broken in Terminal so I made additional changes to support that and the rest of the default emacs key bindings.

@notpeter notpeter merged commit 66ada3e into zed-industries:main Jul 28, 2024
10 checks passed
@CharlesChen0823 CharlesChen0823 deleted the add_keybinding_terminal branch July 29, 2024 01:06
notpeter added a commit that referenced this pull request Jul 31, 2024
@notpeter
Copy link
Member

Turns out that change is unnecessary and this can be controlled via terminal.option_as_meta in settings.

In #15535 I'm reverting this and changing the option_as_meta default to true.
This will land in Zed Preview later today and in Zed Stable in a week (2024-08-06).

Until then you can add the following to your settings:

  "terminal": {
    "option_as_meta": true
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal: emacs shortcuts not working: alt-f, ctrl-f, alt-b, etc.
2 participants