Added PHC-related logs #3036
Merged
Added PHC-related logs #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanZavodskikh
commented
Apr 22, 2024
RomanZavodskikh
force-pushed
the
phc-logs
branch
from
f8ffbe8
to
84e4872
Compare
szuecs
reviewed
Apr 22, 2024
szuecs
reviewed
Apr 22, 2024
RomanZavodskikh
force-pushed
the
phc-logs
branch
from
84e4872
to
17f2584
Compare
proxy/healthy_endpoints.go
Outdated
| @@ -21,7 +21,8 @@ func (h *healthyEndpoints) filterHealthyEndpoints(endpoints []routing.LBEndpoint | |||
| filtered := make([]routing.LBEndpoint, 0, len(endpoints)) | |||
| for _, e := range endpoints { | |||
| if p < e.Metrics.HealthCheckDropProbability() { | |||
| /* drop */ | |||
| ctx.Logger().Infof("dropping endpoint %q due to passive health check: p=%0.2f, dropProbability=%0.2f", | |||
There was a problem hiding this comment.
maybe use normal logrus? No need to pass it I mean
There was a problem hiding this comment.
I still would like to have ctx.Logger() here: after #2269 it has useful feature, it adds traceId inside log entry. It may be very helpful to see the relation between trace and log entry during debugging.
|
My concern is that we can flood logs with this. Lets try but we need to keep an eye and may need to disable/move to debug level these logs. |
RomanZavodskikh
force-pushed
the
phc-logs
branch
from
17f2584
to
1edb92b
Compare
We discussed this topic in the meeting:
|
Signed-off-by: Roman Zavodskikh <[email protected]>
RomanZavodskikh
force-pushed
the
phc-logs
branch
from
1edb92b
to
f5f2c6d
Compare
|
👍 |
1 similar comment
|
👍 |
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Zavodskikh [email protected]