Added PHC-related logs (#3036)

Signed-off-by: Roman Zavodskikh <[email protected]> Co-authored-by: Roman Zavodskikh <[email protected]>
zalando · Apr 23, 2024 · 4db806b · 4db806b
1 parent 708e97a
commit 4db806b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/proxy/healthy_endpoints.go b/proxy/healthy_endpoints.go
@@ -11,7 +11,7 @@ type healthyEndpoints struct {
 	endpointRegistry *routing.EndpointRegistry
 }
 
-func (h *healthyEndpoints) filterHealthyEndpoints(endpoints []routing.LBEndpoint, rt *routing.Route) []routing.LBEndpoint {
+func (h *healthyEndpoints) filterHealthyEndpoints(ctx *context, endpoints []routing.LBEndpoint) []routing.LBEndpoint {
 	if h == nil {
 		return endpoints
 	}
@@ -20,8 +20,10 @@ func (h *healthyEndpoints) filterHealthyEndpoints(endpoints []routing.LBEndpoint
 
 	filtered := make([]routing.LBEndpoint, 0, len(endpoints))
 	for _, e := range endpoints {
-		if p < e.Metrics.HealthCheckDropProbability() {
-			/* drop */
+		dropProbability := e.Metrics.HealthCheckDropProbability()
+		if p < dropProbability {
+			ctx.Logger().Infof("Dropping endpoint %q due to passive health check: p=%0.2f, dropProbability=%0.2f",
+				e.Host, p, dropProbability)
 		} else {
 			filtered = append(filtered, e)
 		}

diff --git a/proxy/proxy.go b/proxy/proxy.go
@@ -540,7 +540,7 @@ func (p *Proxy) selectEndpoint(ctx *context) *routing.LBEndpoint {
 	rt := ctx.route
 	endpoints := rt.LBEndpoints
 	endpoints = p.fadein.filterFadeIn(endpoints, rt)
-	endpoints = p.heathlyEndpoints.filterHealthyEndpoints(endpoints, rt)
+	endpoints = p.heathlyEndpoints.filterHealthyEndpoints(ctx, endpoints)
 
 	lbctx := &routing.LBContext{
 		Request:     ctx.request,

diff --git a/routing/endpointregistry.go b/routing/endpointregistry.go
@@ -5,6 +5,8 @@ import (
 	"sync/atomic"
 	"time"
 
+	log "github.com/sirupsen/logrus"
+
 	"github.com/zalando/skipper/eskip"
 )
 
@@ -166,6 +168,9 @@ func (r *EndpointRegistry) updateStats() {
 			requests := e.totalRequests[curSlot].Load()
 			if requests > r.minRequests {
 				failedRoundTripsRatio := float64(failed) / float64(requests)
+				if failedRoundTripsRatio > 0.0 {
+					log.Infof("Passive health check: marking %q as unhealthy due to failed round trips ratio: %0.2f", key, failedRoundTripsRatio)
+				}
 				e.healthCheckDropProbability.Store(min(failedRoundTripsRatio, r.maxHealthCheckDropProbability))
 			} else {
 				e.healthCheckDropProbability.Store(0.0)