Provide TraceID in the logs

[RomanZavodskikh]

Signed-off-by: Roman Zavodskikh [email protected]

[AlexanderYastrebov]

Please describe the problem it solves. Is this open tracing relevant only? Do we need to log it for each log statement or only for selected logs?
See also https://github.com/sirupsen/logrus#fields

[RomanZavodskikh]

@AlexanderYastrebov this is a draft PR for me to create a test image and use this image to check how will it work (and would it work at all) to provide traceID inside all logs. I just picked up some logs but hope this change to have an effect on all possible logs.

[AlexanderYastrebov]

Format string should always be a constant. Imagine what happens if buf contains format specifier e.g. %:

package main

import "fmt"

func main() {
	buf := "%s"
	fmt.Printf("Response for " + buf)
}

outputs

Response for %!s(MISSING)

The proper way is ctx.Logger().Infof("Response for %s", buf).
The same applies to ctx.Logger().Errorf(err.Error()) as error message potentially may contain format specifiers.

See also https://owasp.org/www-community/attacks/Format_string_attack

[AlexanderYastrebov]

👍

[RomanZavodskikh]

👍