skipper: update hostname-credentials-controller #7120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
the
major
szuecs
reviewed
Mar 4, 2024
| @@ -4,6 +4,20 @@ pre_apply: | |||
| namespace: kube-system | |||
| kind: Deployment | |||
|
|
|||
| # TODO: remove after rollout | |||
|
👍 |
The logic previously implemented by secret-combiner was moved into hostname-credentials-controller. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
skipper/update-hostname-credentials
branch
from
7755b14 to
5ee1f4d
Compare
|
👍 |
1 similar comment
|
👍 |
Merged
AlexanderYastrebov
added a commit
that referenced
this pull request
Mar 5, 2024
Follow up on #5851 and #7120 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Mar 5, 2024
Follow up on #5851, #5857 and #7120 Signed-off-by: Alexander Yastrebov <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic previously implemented by secret-combiner was moved into hostname-credentials-controller.