Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cronjob-monitor #5851

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Remove cronjob-monitor #5851

merged 1 commit into from
Mar 21, 2023

Conversation

mikkeloscar
Copy link
Contributor

@mikkeloscar mikkeloscar commented Mar 21, 2023

This removes the cronjob-monitor component which is no longer needed since Kubernetes v1.22.

This component was setting the annotation experimental.zalando.org/last-successful-completion-time on successful cronjobs which was used in ZMON monitoring. Since Kubernetes v1.22 the same data is natively available in the status.lastSuccessfulTime field and ZMON is already relying on that.

@mikkeloscar mikkeloscar marked this pull request as ready for review March 21, 2023 09:16
@zaklawrencea
Copy link
Member

zaklawrencea commented Mar 21, 2023

..removed to wait for e2e

Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
@mikkeloscar mikkeloscar force-pushed the drop-cronjob-monitor branch from 5936fc9 to fd2a075 Compare March 21, 2023 10:07
@linki
Copy link
Member

linki commented Mar 21, 2023

👍

1 similar comment
@mikkeloscar
Copy link
Contributor Author

👍

@mikkeloscar mikkeloscar merged commit ef16c6c into dev Mar 21, 2023
@mikkeloscar mikkeloscar deleted the drop-cronjob-monitor branch March 21, 2023 13:04
This was referenced Mar 21, 2023
AlexanderYastrebov added a commit that referenced this pull request Mar 5, 2024
Follow up on #5851 and #7120

Signed-off-by: Alexander Yastrebov <[email protected]>
@AlexanderYastrebov AlexanderYastrebov mentioned this pull request Mar 5, 2024
1 task
AlexanderYastrebov added a commit that referenced this pull request Mar 5, 2024
Follow up on #5851, #5857 and #7120

Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants