Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cronjob-monitor cleanup in post-apply #5857

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

mikkeloscar
Copy link
Contributor

@mikkeloscar mikkeloscar commented Mar 22, 2023

Trying to delete a VerticalPodAutoscaler resource in pre_apply breaks e2e because the VerticalPodAutoscaler resource type will not be available the very first time a cluster is set up. Therefore move it to post_apply to avoid this problem.

Follow up to #5851

Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
@mikkeloscar
Copy link
Contributor Author

👍

1 similar comment
@demonCoder95
Copy link
Member

👍

@mikkeloscar mikkeloscar merged commit b8d3ec3 into dev Mar 22, 2023
@mikkeloscar mikkeloscar deleted the cronjob-monitor-cleanup-fix branch March 22, 2023 13:45
This was referenced Mar 22, 2023
AlexanderYastrebov added a commit that referenced this pull request Mar 5, 2024
Follow up on #5851, #5857 and #7120

Signed-off-by: Alexander Yastrebov <[email protected]>
@AlexanderYastrebov AlexanderYastrebov mentioned this pull request Mar 5, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants