Packet Integrity Check

[yhju]

Actual implementation to prevent communication failure due to malformed bytestream.

[stonier]

What are you thinking about here YH? I haven't been able to think up any improvements on this one.

[stonier]

Follow this up and close it.

[yhju]

Done by 4648538.

[yhju]

found another place for improvements

[yhju]

Done.

[stonier]

This a relatively large commit - can you briefly explain what you did here?

Was there also a second commit? If so, link it.

[yhju]

All related commits are already listed in this page.

9 month ago, I added length field in sub-payload of protocol for compatibility among various firmware - driver pairs. Issue #168.

But, driver was not actually using it in packet validation. There was also no actual exception handling on validation failure, when packet class return false on deserialize call, such as removing malformed sub-payload. It will fall in infinite while loop.

Commit Summary

4648538:

• added packet validity check in each packet class.

27c62af:

• added fixPayload function, by moving code of default case in packet parsing.
• when packet class return false on deserialize call, fixPayload will actually fix it.
• added getPayload function on packet_handler that provide just payload only, except header, length field of payload, and checksum for more clear packet parsing and processing.

[stonier]

Ok, thanks.

Do we need to test this thoroughly next week or have you been using it for a while?

[yhju]

It is very recent commit, and I tested it shortly. We need some test.

[stonier]

I would prefer not to have critical driver functionality updates going in the day before a major release without any testing.

Would have been better more than a week ago, or delayed until some decent testing on it saw it through. We'll manage this time, but please be a bit more careful before a major product release next time.