Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] change default storage option for AWS provider to 1x250GB #5919

Closed
rao-vasireddy opened this issue Oct 2, 2020 · 6 comments
Closed

[Platform] change default storage option for AWS provider to 1x250GB #5919

rao-vasireddy opened this issue Oct 2, 2020 · 6 comments
Assignees
@jitendra-12113
Labels
area/platform Yugabyte Platform good first issue This is a good issue to start contributing! kind/enhancement This is an enhancement of an existing feature team/platform-hi Tickets handled by HashedIn team
Milestone
2.5.x

Comments

@rao-vasireddy
Copy link
Contributor

No description provided.

@rao-vasireddy rao-vasireddy added the kind/enhancement This is an enhancement of an existing feature label Oct 2, 2020
@streddy-yb streddy-yb added the good first issue This is a good issue to start contributing! label Oct 26, 2020
@streddy-yb streddy-yb added this to the v2.5 milestone Oct 26, 2020
@streddy-yb streddy-yb added area/platform Yugabyte Platform team/platform-hi Tickets handled by HashedIn team labels Dec 8, 2020
@jaydeepkumara jaydeepkumara assigned gaurav061 and unassigned chirag-yb Dec 10, 2020
@gaurav061
Copy link
Contributor

Current Behaviour: Number of instance that is set as default is being determined by the length of volumeDetailsList, which is the subset of instance type list, for most of the instance type this length is 2, but for some of them it is 1(i3.large and i3.xlarge), So Should i make this as hard coded value 1 for all instance type?

@jitendra-12113
Copy link
Contributor

jitendra-12113 commented Dec 17, 2020 •
edited
Loading

Back end changes are done. Can someone please review this code?
#6688

UI has to consume volumeCount field to show volumeCountInfo - TO DO
cc: @gaurav061

@jitendra-12113
Copy link
Contributor

Setting up the volumeCount for aws provider to 1 whose instanceType starting with c5/c4.

@gaurav061
Copy link
Contributor

Please find the PR for this ticket:
#6688

@jitendra-12113
Copy link
Contributor

Raised another PR for this ticket. Unit tests are included. Please review.
#6742

@sb-yb sb-yb linked a pull request Dec 24, 2020 that will close this issue
[#5919] Platform: change default storage option for AWS provider to 1x250GB #6742
Closed
jitendra-12113 pushed a commit that referenced this issue Dec 28, 2020
Heading:
f7e9a4f 
[#5919] Platform: change default storage option for AWS provider to 1x250GB
Description:
We wanted to show default volume count to 1 on the UI for all the instance types starting with "c5./c4."
Testing:
When we select aws provider while creating universe, volume count was showing more than one for some instances types starting with ""c5./c4.". Now with this fix it will show one one.
Added Unit test as well.
jitendra-12113 pushed a commit that referenced this issue Dec 29, 2020
[#5919] Platform: change default storage option for AWS provider to 1…
1a94d04 
…x250GB

Heading:
[5919][Platform] change default storage option for AWS provider to 1x250GB
Description:
We wanted to show default volume count to 1 on the UI for all the instance types starting with "c5./c4."
Testing:
When we select aws provider while creating universe, volume count was showing more than one for some instances types starting with ""c5./c4.". Now with this fix it will show only one.
Added Unit test as well.
jitendra-12113 pushed a commit that referenced this issue Dec 30, 2020
[#5919] Platform: change default storage option for AWS provider to 1…
fdf8fea 
…x250GB

Heading:
[5919][Platform] change default storage option for AWS provider to 1x250GB
Description:
We wanted to show default volume count to 1 on the UI for all the instance types starting with "c5./c4."
Testing:
When we select aws provider while creating universe, volume count was showing more than one for some instances types starting with ""c5./c4.". Now with this fix it will show only one.
Added Unit test as well.
@chirag-yb chirag-yb modified the milestones: v2.5, 2.5.x Jan 4, 2021
jitendra-12113 pushed a commit that referenced this issue Jan 5, 2021
Heading:
1f79e0c 
[#5919] Platform: change default storage option for AWS provider to 1x250GB
Description:
We wanted to show default volume count to 1 on the UI for all the instance types starting with "c5./c4."
Testing:
When we select aws provider while creating universe, volume count was showing more than one for some instances types starting with ""c5./c4.". Now with this fix it will show only one.
Will have to reset instanceTypeDetailsJson to empty for older YW
instances.
This was referenced Jan 5, 2021
Closed
Merged
@jitendra-12113
Copy link
Contributor

@sb-yb As discussed, made the necessary changes. Created another CR for the same.
#6792
Please review! Thanks!

jitendra-12113 added a commit that referenced this issue Jan 19, 2021
@jitendra-12113
Heading: (#6792)
47122ef 
[#5919] Platform: change default storage option for AWS provider to 1x250GB
Description:
We wanted to show default volume count to 1 on the UI for all the instance types starting with "c5./c4."
Testing:
When we select aws provider while creating universe, volume count was showing more than one for some instances types starting with ""c5./c4.". Now with this fix it will show only one.
Will have to reset instanceTypeDetailsJson to empty for older YW
instances.

Co-authored-by: Jitendra Kumar <[email protected]>
@streddy-yb streddy-yb mentioned this issue Feb 8, 2021
Closed
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this issue Mar 9, 2021
@jitendra-12113
Heading: (yugabyte#6792)
cd61595 
[yugabyte#5919] Platform: change default storage option for AWS provider to 1x250GB
Description:
We wanted to show default volume count to 1 on the UI for all the instance types starting with "c5./c4."
Testing:
When we select aws provider while creating universe, volume count was showing more than one for some instances types starting with ""c5./c4.". Now with this fix it will show only one.
Will have to reset instanceTypeDetailsJson to empty for older YW
instances.

Co-authored-by: Jitendra Kumar <[email protected]>
@nyndyny nyndyny mentioned this issue Oct 28, 2023
Open
@ryan-ally ryan-ally mentioned this issue Oct 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jitendra-12113 jitendra-12113

Labels
area/platform Yugabyte Platform good first issue This is a good issue to start contributing! kind/enhancement This is an enhancement of an existing feature team/platform-hi Tickets handled by HashedIn team
Projects
None yet
Milestone
2.5.x
Development

Successfully merging a pull request may close this issue.

[#5919] Platform: change default storage option for AWS provider to 1x250GB yugabyte/yugabyte-db
7 participants
@Arnav15 @jaydeepkumara @rao-vasireddy @jitendra-12113 @gaurav061 @chirag-yb @streddy-yb