test #6688
test #6688
Conversation
|
Jitendra Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Setting up the volumeCount for aws provider to 1 whose instanceType starting with c5/c4. |
|
Kindly review the changes, |
| // setting up the volumeCount to 1 for instanceType starting with c5/c4 | ||
| for (InstanceType instanceType: instanceTypeList) { | ||
| if (provider.code.equals(aws.toString()) && | ||
| ((instanceType.idKey.instanceTypeCode.startsWith("c5")) || |
There was a problem hiding this comment.
This is incorrect. c5d instances are similar to i3 instances in that they use NVMe drives. So we want to use the value present in the details.
There was a problem hiding this comment.
Thanks @Arnav15 for confirming this. Will do this only for c4/C5 instance type which won't include c5d.
Will do necessary changes and update CR.
| @@ -608,7 +609,7 @@ export default class ClusterFields extends Component { | |||
| if (volumeDetail) { | |||
| const deviceInfo = { | |||
| volumeSize: volumeDetail.volumeSizeGB, | |||
| numVolumes: volumesList.length, | |||
| numVolumes: volumeCount, | |||
There was a problem hiding this comment.
could you please update logic here as well
|
Will raise another PR. |
No description provided.