Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Onprem provider page does not load due to missing instance types #6919

Closed
WesleyW opened this issue Jan 19, 2021 · 1 comment
Closed

[Platform] Onprem provider page does not load due to missing instance types #6919

WesleyW opened this issue Jan 19, 2021 · 1 comment
Assignees
@WesleyW
Labels
area/platform Yugabyte Platform
Milestone
2.5.x

Comments

@WesleyW
Copy link
Contributor

WesleyW commented Jan 19, 2021

When accessing the onprem provider page, the UI will crash because the API does not return the instance types required.
@WesleyW WesleyW added the area/platform Yugabyte Platform label Jan 19, 2021
@WesleyW WesleyW self-assigned this Jan 19, 2021
WesleyW added a commit that referenced this issue Jan 19, 2021
@WesleyW
#6919: Fix crashing onprem provider page due to missing instance type…
11d08f6 
… details

Summary:
Fixed regression where the `InstanceTypesController.get` method will not return the
`instance_type_details_json` for onprem providers, which will cause the UI to crash.

Test Plan:
Create onprem provider and check if page loads.
Create AWS provider and check if page loads.

sbt "test-only com.yugabyte.yw.models.InstanceTypeTest"

Reviewers: sb-yb, arnav, daniel, spotachev

Reviewed By: spotachev

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D10391
@streddy-yb streddy-yb added this to the 2.5.x milestone Jan 19, 2021
@streddy-yb
Copy link
Contributor

This is not required in 2.4 as this is a regression from the fix for #5919

polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this issue Mar 9, 2021
@WesleyW
yugabyte#6919: Fix crashing onprem provider page due to missing insta…
76064b9 
…nce type details

Summary:
Fixed regression where the `InstanceTypesController.get` method will not return the
`instance_type_details_json` for onprem providers, which will cause the UI to crash.

Test Plan:
Create onprem provider and check if page loads.
Create AWS provider and check if page loads.

sbt "test-only com.yugabyte.yw.models.InstanceTypeTest"

Reviewers: sb-yb, arnav, daniel, spotachev

Reviewed By: spotachev

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D10391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WesleyW WesleyW

Labels
area/platform Yugabyte Platform
Projects
None yet
Milestone
2.5.x
Development

No branches or pull requests
2 participants
@WesleyW @streddy-yb