[DocDB] Remove non-transactional snapshot code #23428
Assignees
Labels
area/docdb
YugabyteDB core features
kind/enhancement
This is an enhancement of an existing feature
priority/low
Low priority
Comments
SrivastavaAnubhav
added
area/docdb
yugabyte-ci
added
the
kind/enhancement
SrivastavaAnubhav
added a commit
that referenced
this issue
Aug 12, 2024
Summary: Transactional snapshots have been supported (and the default) since D8100 and D8349. The non-transactional snapshot flow is untested and clutters the transactional snapshots. To the best of our knowledge, it is unused. This diff removes the non-transactional snapshot code. **Upgrade/Rollback safety:** This diff deprecates the `transaction_aware` field in `CreateSnapshotRequestPB` and the `current_snapshot_id` field in `ListSnapshotsResponsePB`. Since masters are upgraded before tservers, the `transaction_aware` aware field will always be ignored (the new behavior) on an upgrade / downgrade. The `current_snapshot_id` field is only set for non-transactional snapshots (which are not being used), so that field's behavior does not change. Jira: DB-12349 Test Plan: Existing tests Reviewers: zdrudi, hsunder, loginov Reviewed By: zdrudi, hsunder, loginov Subscribers: loginov, ybase Differential Revision: https://phorge.dev.yugabyte.com/D37010
jasonyb
pushed a commit
that referenced
this issue
Aug 13, 2024
Summary: bd1e19e [PLAT-14835]: Add extra transient YCQL index tables in xClusterTableConfig during GET calls and metrics. 2715c58 [docs] updated yb version with shortcode (#23456) a2b5495 [PLAT-14912] docs warning for install root as subdirectory (#23470) 53365b1 [#23422] YSQL: Disable random warmup feature by default for connection manager tests 09d6e96 [#22876][#22835][#22773] CDCSDK: Add null checks & remove optimisation in table removal from CDC stream 69d4052 [#22862] XCluster: Improving XCluster Index Base WAL Retention Policy 706e97d [#23460] DocDB: Read vector index data b1a90b9 [#23428] docdb: Remove non-transactional snapshot code 581648f [PLAT-13957] Update RBAC wrapper for xCluster DR fbaf945 Whitepaper on migration (#23468) f6af2f5 [PLAT-13936] Upgrade Grpc and its dependencies to fix CVEs d7027fe [PLAT-14892] Update PITR configuration step text 92804ac [PLAT-14760] Use new xCluster sync API 3cb8faf [PLAT-11243] Upgrade python requests to latest version Excluded: a036313 [#23070] YSQL, ASH: Replace ysql_session_id with pid 4d2f71f [PLAT-14882] Retrieve userName from the attribute lists in case not found in dn 99489c0 [PLAT-14909] Upgrade YBC version to 2.2.0.0-b4 Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D37272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-12349
Description
Transactional snapshots have been supported (and the default) since D8100 and D8349. The non-transactional snapshot flow is untested and clutters the transactional snapshots. To the best of our knowledge, it is unused and can be removed.
Issue Type
kind/enhancement
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: