[#23422] YSQL: Disable random warmup feature by default for connectio…

…n manager tests

Summary:
Disable `TEST_ysql_conn_mgr_dowarmup_all_pools_random_attach` in ysql connection manager tests by default introduced as part of [[ https://phorge.dev.yugabyte.com/D36806 | D36806 ]] which creates warmup connections in every pool and randomly allocate server connection to client. This change has lead to failing many ysql connection manager tests by default in master branch. Therefore disabling it for now and working to fix in subsequent diff.

Fixes #23422
Jira: DB-12343

Test Plan:
Jenkins: java only

Ensure all ysql connection manager tests are running successfully.

Reviewers: asrinivasan, skumar, rbarigidad

Reviewed By: rbarigidad

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D37188

java/yb-ysql-conn-mgr/src/test/java/org/yb/ysqlconnmgr/BaseYsqlConnMgr.java

@@ -48,8 +48,6 @@ protected void customizeMiniClusterBuilder(MiniYBClusterBuilder builder) {
     builder.numTservers(NUM_TSERVER);
     builder.replicationFactor(NUM_TSERVER);
     builder.addCommonTServerFlag("ysql_conn_mgr_dowarmup", "false");
-    builder.addCommonTServerFlag(
-        "TEST_ysql_conn_mgr_dowarmup_all_pools_random_attach", "true");
   }
 
   protected ConnectionBuilder getConnectionBuilder() {

src/yb/yql/ysql_conn_mgr_wrapper/ysql_conn_mgr_wrapper.cc

@@ -112,9 +112,11 @@ Status YsqlConnMgrWrapper::Start() {
   auto ysql_conn_mgr_executable = GetYsqlConnMgrExecutablePath();
   RETURN_NOT_OK(CheckExecutableValid(ysql_conn_mgr_executable));
 
-  if (FLAGS_TEST_ysql_conn_mgr_dowarmup_all_pools_random_attach &&
-      FLAGS_ysql_conn_mgr_min_conns_per_db < 3) {
-    FLAGS_ysql_conn_mgr_min_conns_per_db = 3;
+  if (FLAGS_TEST_ysql_conn_mgr_dowarmup_all_pools_random_attach) {
+    LOG(INFO) << "Warmup and random allotment of server connections is enabled in "
+    "ysql connection manager";
+    if (FLAGS_ysql_conn_mgr_min_conns_per_db < 3)
+      FLAGS_ysql_conn_mgr_min_conns_per_db = 3;
   }
 
   std::vector<std::string> argv{