Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USD contribution: Set up different default values based on profiles #973

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Oct 26, 2024

Changelog Description

Follow up PR to: #994 so that USD products will use different attribute defaults based on profiles.

Additional info

TODO

  • Implement profiles in settings
  • Allow to also filter profiles against e.g. task type

Testing notes:

  1. Use together with PR here: Allow creating more product types as USD with USD contribution workflow and better defaults. ayon-houdini#144
  2. In Houdini, start publishing USD model, groom and look products. Each product should have different defaults and target the right 'default layer'

@MustafaJafar
Copy link
Contributor

MustafaJafar commented Oct 29, 2024

Hey,
This PR enhances many aspects:

  • Dev: From pyblish plugins dev perspective, this PR helps understanding the intention of the creators. also, it helps making the system more modular as I can add as many attributes using different plugins.
  • Artist: I can find attributes related to my publish instance.

Note

I made a draft PR ynput/ayon-houdini#148 to show case my test for this PR. (It shows the issue of the difference between product type and families as mentioned here #973 (comment). but, it doesn't leverage this PR), so, I tried one more time.

This example show cases the benefit from this PR.
where I needed to

  1. add the necessary families to get_publish_families
  2. implement the proper callbacks to show and hide attributes in the publisher (taking USD Contribution Workflow: Show/hide attributes per instance based on status of other toggles #960 as reference).

The draft PRs where I took this screengrab are: ynput/ayon-houdini#149, ynput/ayon-deadline#54
Animation_17

@BigRoy BigRoy changed the title Show publish plug-in attributes based on families instead of only productType USD contribution: Set up different default values based on profiles Nov 6, 2024
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Dec 30, 2024

I have a question: Why are used profiles? You have quite deterministic way how it's defined, and it looks like it is not based on settings, you can just have if statements -> more specific and clear why it actually happens...

Nevermind I just saw in description it is meant to be based on settings. But does it make sense to have it in settings? How someone, non-developer, will be able to fill the values correctly?

@BigRoy
Copy link
Collaborator Author

BigRoy commented Dec 30, 2024

Nevermind I just saw in description it is meant to be based on settings. But does it make sense to have it in settings? How someone, non-developer, will be able to fill the values correctly?

Basically by "product type" (which is the profile) define the defaults for the attributes. Somewhat similar to what the Collect Job Info now does in ayon-deadline but with much less attributes ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants