Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize notation of farm destined instance #57

Open
1 task done
kalisp opened this issue Nov 5, 2024 · 1 comment
Open
1 task done

Standardize notation of farm destined instance #57

kalisp opened this issue Nov 5, 2024 · 1 comment
Assignees
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@kalisp
Copy link
Member

kalisp commented Nov 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues and added correct labels.

Please describe the feature you have in mind and explain what the current shortcomings are?

Currently we are marking farm destined instances with instance.data["farm"] = True and we are checking against it.

This flag is also important to show farm only attribute definitions (for JobInfo for example) in Publisher UI.

Suggested implementation?

There should be added new method is_farm_instance to encapsulate it and replace all existing uses of old one to allow changes in logic in single place.

Describe alternatives you've considered:

No response

@kalisp kalisp self-assigned this Nov 5, 2024
@BigRoy
Copy link
Contributor

BigRoy commented Nov 5, 2024

I'd actually like to make it so that the we use farm family instead and have it listed by the creators - as per ynput/ayon-core#973

I mean - doing it based on instance.data.get("farm") tecnically isn't that different, but by using families like that it also allows us to ensure that we're always targeting our deadline plug-ins to run on them as intended if they happen to have the farm family. and we can remove the whole FARM_FAMILIES constant which generates issues between e.g. Tray Publisher, Fusion, Maya, etc. where in tray publisher e.g. a render instance may not support farm publishing at all, but a maya one does. But with the #49 PR suddenly tray publisher will also show those attributes?

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

2 participants