-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USD Contribution Workflow: Show/hide attributes per instance based on status of other toggles #960
USD Contribution Workflow: Show/hide attributes per instance based on status of other toggles #960
Conversation
client/ayon_core/plugins/publish/extract_usd_layer_contributions.py
Outdated
Show resolved
Hide resolved
…er_instance_toggle
…ggle' of https://github.com/BigRoy/ayon-core into enhancement/usd_contribution_attributes_per_instance_toggle
It works in Houdini but, there's a weird error print in the console. ERROR:CreateContext:Failed to get attribute definitions from plugin 'CollectUSDLayerContributionsHoudiniLook'.
Traceback (most recent call last):
File "E:\Ynput\ayon-core\client\ayon_core\pipeline\create\context.py", line 1254, in bulk_add_instances
attr_defs = plugin.get_attr_defs_for_instance(
File "E:\Ynput\ayon-core\client\ayon_core\plugins\publish\extract_usd_layer_contributions.py", line 606, in get_attr_defs_for_instance
layer_def = next(d for d in defs if d.key == "contribution_layer")
StopIteration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Houdini, Maya and Blender. It works.
The issue mentioned in my previous comments shows only in Houdini.
I furtherly checked this, firstly I added a print statement inside the CollectUSDLayerContributionsHoudiniLook.get_attr_defs_for_instance next(i for i in range(4) if i > 5) Edit 1: the error is gone when adding the following condition before this line
|
Thanks so much for catching that @MustafaJafar. Fixed with 11bb657 |
Cool The error has disappeared. |
…er_instance_toggle
Please review @iLLiCiTiT and merge if happy with the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise looks ok. If it works happy to merge.
…er_instance_toggle
Changelog Description
Show/hide attributes per instance for the USD contribution workflow based on status of other toggles in the Publisher UI.
Additional info
Replaces PR #943 which I couldn't seem to retarget to
develop
anymoreTesting notes:
See screenshots: