Merge feature from #4793 and #4996 to set frame range on instances #5201

ClementHector · 2023-06-27T17:47:05Z

Changelog Description

New PR that brings together the work of:
#4793
#4996
The two PR is no longer functional, it now works with the latest update_frame_range changes.

Testing notes:

Open Maya Scene with wrong frame range in instances
Click set frame range button to solve this problem
Or
Build scene with Build workfile template
See all instances with the right frame range

Author: Thomas Fricard <[email protected]> Date: Mon May 15 17:12:13 2023 +0200 cosmetic refactoring commit 6fcb0a6 Author: Thomas Fricard <[email protected]> Date: Mon May 15 16:55:19 2023 +0200 check id attribute before family attribute commit df6cc8c Author: Thomas Fricard <[email protected]> Date: Fri May 12 16:01:52 2023 +0200 verify that 'family' attributes exists and equals to 'render' commit 5ae1847 Author: Thomas Fricard <[email protected]> Date: Fri May 12 15:58:05 2023 +0200 change function name + docstrings commit ff09bbb Author: Thomas Fricard <[email protected]> Date: Fri May 12 11:48:43 2023 +0200 add a 'type' key to the 'include handles' setting of maya commit ec96832 Author: Thomas Fricard <[email protected]> Date: Wed May 3 15:32:06 2023 +0200 merge and refactor functions to updte asset frame range commit 661f494 Author: Thomas Fricard <[email protected]> Date: Tue Apr 18 10:03:24 2023 +0200 add 'instances' to reset_frame_range function arguments and make sure it does not update frame range instances on creating render settings commit a10ecfc Merge: 19836b3 196f698 Author: Thomas Fricard <[email protected]> Date: Tue Apr 18 09:32:32 2023 +0200 Merge branch '346-fix-studio-openpype-udpate-frame-range-of-scene-doesn-t-update-frame-range-in-animation-instance' of github.com:quadproduction/OpenPype into 346-fix-studio-openpype-udpate-frame-range-of-scene-doesn-t-update-frame-range-in-animation-instance commit 19836b3 Author: Thomas Fricard <[email protected]> Date: Tue Apr 18 09:31:27 2023 +0200 change key and label to make the setting more understandable commit 196f698 Merge: 155a0c2 515c0ac Author: Thomas Fricard <[email protected]> Date: Thu Apr 13 11:06:26 2023 +0200 Merge branch 'develop' into 346-fix-studio-openpype-udpate-frame-range-of-scene-doesn-t-update-frame-range-in-animation-instance commit 155a0c2 Author: Thomas Fricard <[email protected]> Date: Thu Apr 13 10:57:53 2023 +0200 resolve conflicts commit 6a6c9e0 Author: Thomas Fricard <[email protected]> Date: Wed Apr 12 14:07:19 2023 +0200 check if update instances is enabled in settings commit 9211c4a Author: Thomas Fricard <[email protected]> Date: Wed Apr 12 13:58:40 2023 +0200 add a setting in maya project settings to enable updating animation instances commit fde0b50 Author: Thomas Fricard <[email protected]> Date: Tue Apr 11 16:58:37 2023 +0200 check if attribute exsits before modifying it commit 38eed31 Author: Thomas Fricard <[email protected]> Date: Wed Apr 5 15:26:04 2023 +0200 update animation instance frames attribute on reset frame range commit dc47ca9 Author: Thomas Fricard <[email protected]> Date: Fri Mar 31 15:56:19 2023 +0200 get instances and set frameStart attribute commit 0932341 Author: Thomas Fricard <[email protected]> Date: Wed May 17 12:47:17 2023 +0200 call reset_frame_range function for instances after importing commit 4de8e6e Author: Thomas Fricard <[email protected]> Date: Mon May 15 17:12:13 2023 +0200 cosmetic refactoring commit efe2dbb Author: Thomas Fricard <[email protected]> Date: Mon May 15 16:55:19 2023 +0200 check id attribute before family attribute commit 2379c5c Author: Thomas Fricard <[email protected]> Date: Fri May 12 16:01:52 2023 +0200 verify that 'family' attributes exists and equals to 'render' commit 3a57274 Author: Thomas Fricard <[email protected]> Date: Fri May 12 15:58:05 2023 +0200 change function name + docstrings commit 7f68109 Author: Thomas Fricard <[email protected]> Date: Fri May 12 11:48:43 2023 +0200 add a 'type' key to the 'include handles' setting of maya commit 58fb563 Author: Thomas Fricard <[email protected]> Date: Wed May 3 15:32:06 2023 +0200 merge and refactor functions to updte asset frame range commit 49401c7 Author: Thomas Fricard <[email protected]> Date: Tue Apr 18 10:03:24 2023 +0200 add 'instances' to reset_frame_range function arguments and make sure it does not update frame range instances on creating render settings commit 8c0c60d Author: Thomas Fricard <[email protected]> Date: Tue Apr 18 09:31:27 2023 +0200 change key and label to make the setting more understandable commit bdcdab2 Author: Thomas Fricard <[email protected]> Date: Thu Apr 13 10:57:53 2023 +0200 resolve conflicts commit 9040302 Author: Thomas Fricard <[email protected]> Date: Wed Apr 12 14:07:19 2023 +0200 check if update instances is enabled in settings commit cd884e8 Author: Thomas Fricard <[email protected]> Date: Wed Apr 12 13:58:40 2023 +0200 add a setting in maya project settings to enable updating animation instances commit 981c0b1 Author: Thomas Fricard <[email protected]> Date: Tue Apr 11 16:58:37 2023 +0200 check if attribute exsits before modifying it commit 1755ce4 Author: Thomas Fricard <[email protected]> Date: Wed Apr 5 15:26:04 2023 +0200 update animation instance frames attribute on reset frame range commit fdf6f43 Author: Thomas Fricard <[email protected]> Date: Fri Mar 31 15:56:19 2023 +0200 get instances and set frameStart attribute

tokejepsen · 2023-06-28T09:11:34Z

Tested in Maya 2023 successfully. Code looks good to me.

openpype/hosts/maya/api/lib.py

openpype/hosts/maya/api/workfile_template_builder.py

Co-authored-by: Roy Nieterau <[email protected]>

Minkiu

Haven't tested it, but code looks good.

openpype/hosts/maya/api/lib.py

openpype/hosts/maya/api/workfile_template_builder.py

openpype/hosts/maya/api/lib.py

openpype/hosts/maya/api/workfile_template_builder.py

openpype/hosts/maya/api/lib.py

Co-authored-by: Roy Nieterau <[email protected]>

openpype/hosts/maya/api/lib.py

BigRoy · 2023-07-03T18:53:31Z

openpype/hosts/maya/api/workfile_template_builder.py

+        update_instances_frame_range()
+        update_instances_asset_attribute()


Are we sure this is in the right place. cleanup_placeholder sounds like it runs per placeholder instead of at the very end of workfile build. We only want to run this once, right? Not every single time.

I feel like this is probably in the wrong place.

Well seen, it is true that it is executed at each placeholder. I think we should move this to here with a post_populate_scene_placeholders method but we don't can't call maya commands here, maybe we should implement instance-related commands in host class? maybe it doesn't make sense with the new publisher (which I don't know)?
Tell me what would make more sense.

I feel like the abstract workfile builder is missing some methods that trigger before the build and after the build. We could expose a after_build_process() and pre_build_process() so that each DCC could implement its own callbacks that run before or after ALL placeholders. Not sure if the best approach and whether it's really missing - but couldn't quickly find a feature that does that.

Another way could be for the workfile building to emit events emit_event("workfile.before.build") and emit_event("workfile.after.build") so that any module could attach callbacks to the events using register_event_callback - which the host itself could do e.g. on install() etc.

Not sure which would be the best approach. @iLLiCiTiT @tokejepsen @antirotor thoughts?

openpype/hosts/maya/api/lib.py

openpype/hosts/maya/api/pipeline.py

Co-authored-by: Roy Nieterau <[email protected]>

…e-345-and-389-to-set-frame-range-on-animation-instance

openpype/hosts/maya/api/lib.py

Co-authored-by: Roy Nieterau <[email protected]>

BigRoy · 2023-07-06T15:27:05Z

openpype/hosts/maya/api/lib.py

+def update_instances_frame_range():
+    """Update 'frameStart', 'frameEnd', 'handleStart', 'handleEnd' and 'fps'
+    attributes of publishable instances (their objectSets) that got one.
+    """
+
+    attributes = ["frameStart", "frameEnd", "handleStart", "handleEnd", "fps"]
+
+    attrs_per_instance = {}
+    for instance in iter_publish_instances():
+        instance_attrs = [
+            attr for attr in attributes
+            if cmds.attributeQuery(attr, node=instance, exists=True)
+        ]
+
+        if instance_attrs:
+            attrs_per_instance[instance] = instance_attrs
+
+    if not attrs_per_instance:
+        # no instances with any frame related attributes
+        return
+
+    fields = ["data.{}".format(key) for key in attributes]
+    asset_doc = get_current_project_asset(fields=fields)
+    asset_data = asset_doc["data"]
+
+    for node, attrs in attrs_per_instance.items():
+        for attr in attrs:
+            plug = "{}.{}".format(node, attr)
+            value = asset_data[attr]
+            cmds.setAttr(plug, value)


One minor note about this - say you have an instance that does not match the current shot. :) Would we want it to reset to the fream range of the asset it's publishing to, or the one of the currently publishing from?

Currently it does the latter.

In this case it seems that the option which deactivates the update on the instances is not sufficient! Should this option be a filter on the name of the instances?

In this case it seems that the option which deactivates the update on the instances is not sufficient! Should this option be a filter on the name of the instances?

Sorry, could you elaborate? Not sure what you mean with it being not sufficient?

iLLiCiTiT · 2023-07-13T08:26:20Z

I have maybe stupid comment, but isn't this PR outdated since this PR #4388 ?

BigRoy · 2023-07-13T08:35:31Z

I have maybe stupid comment, but isn't this PR outdated since this PR #4388 ?

Yes, I think so. Some of the logic still makes sense to keep - like updating the frame ranges, etc. but likely will need a decent overhaul to work with the new Creator system instead.

tokejepsen · 2024-01-16T07:21:04Z

@ClementHector what is the status of this PR? Are you using the new Creator/Publisher?

mkolar · 2024-01-25T22:42:10Z

@ClementHector we're closing this PR as it is now stale and obsolete. If there is any functionality from this you'd like to contribute again, feel free to re-open this again, targeting AYON

ynbot added host: Maya size/S Denotes a PR changes 100-499 lines, ignoring general files labels Jun 27, 2023

ClementHector force-pushed the 483-merge-feature-345-and-389-to-set-frame-range-on-animation-instance branch from d401984 to 92f5046 Compare June 27, 2023 18:23

ClementHector changed the title ~~483 merge feature 345 and 389 to set frame range on animation instance~~ 483 merge feature 345 and 389 to set frame range on instances Jun 27, 2023

ClementHector changed the title ~~483 merge feature 345 and 389 to set frame range on instances~~ Merge feature from #345 and #389 to set frame range on instances Jun 27, 2023

ClementHector changed the title ~~Merge feature from #345 and #389 to set frame range on instances~~ Merge feature from #4793 and #4996 to set frame range on instances Jun 28, 2023

ClementHector marked this pull request as ready for review June 28, 2023 08:47

This was referenced Jun 28, 2023

Maya: Update frame range of instances when clicking on "Reset frame range" #4793

Closed

Template Builder: update frames and handles of instances from Ftrack data when building the first scene #4996

Closed

tokejepsen self-requested a review June 28, 2023 09:11

tokejepsen approved these changes Jun 28, 2023

View reviewed changes

tokejepsen assigned tokejepsen and antirotor and unassigned tokejepsen Jun 28, 2023

BigRoy reviewed Jun 28, 2023

View reviewed changes

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

BigRoy reviewed Jun 28, 2023

View reviewed changes

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

BigRoy reviewed Jun 28, 2023

View reviewed changes

openpype/hosts/maya/api/workfile_template_builder.py Outdated Show resolved Hide resolved

ClementHector and others added 2 commits June 28, 2023 16:36

Update openpype/hosts/maya/api/lib.py

002f2c8

Co-authored-by: Roy Nieterau <[email protected]>

remove rendre check

062cf52

mkolar added the community contribution label Jun 28, 2023

add reset_frame_range instance=true

921eb4f

ClementHector requested a review from BigRoy June 28, 2023 15:01

Minkiu approved these changes Jun 28, 2023

View reviewed changes

ClementHector added 2 commits June 28, 2023 22:14

Change reset_frame_range default to false

de4bad2

cosmetic fix

435deed

BigRoy reviewed Jun 28, 2023

View reviewed changes

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

BigRoy reviewed Jun 28, 2023

View reviewed changes

openpype/hosts/maya/api/workfile_template_builder.py Outdated Show resolved Hide resolved

tokejepsen suggested changes Jun 30, 2023

View reviewed changes

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

openpype/hosts/maya/api/workfile_template_builder.py Outdated Show resolved Hide resolved

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

ClementHector and others added 5 commits July 3, 2023 11:43

Update openpype/hosts/maya/api/lib.py

6296fc5

Co-authored-by: Roy Nieterau <[email protected]>

update instance frame range

95b5fff

update instance frame range

079abd0

revert update instance option

399bbec

extract asset update from framerange

8c4e0b7

ClementHector requested review from BigRoy, tokejepsen and iLLiCiTiT July 3, 2023 13:44

BigRoy reviewed Jul 3, 2023

View reviewed changes

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

BigRoy reviewed Jul 3, 2023

View reviewed changes

iter over instance

248a8f6

BigRoy reviewed Jul 4, 2023

View reviewed changes

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

BigRoy reviewed Jul 4, 2023

View reviewed changes

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

BigRoy reviewed Jul 4, 2023

View reviewed changes

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

BigRoy reviewed Jul 4, 2023

View reviewed changes

openpype/hosts/maya/api/pipeline.py Show resolved Hide resolved

ClementHector and others added 4 commits July 4, 2023 15:53

Update openpype/hosts/maya/api/lib.py

359bc65

Co-authored-by: Roy Nieterau <[email protected]>

Update openpype/hosts/maya/api/lib.py

0ec7f99

Co-authored-by: Roy Nieterau <[email protected]>

add update instances asset name

d96495e

Merge remote-tracking branch 'upstream/develop' into 483-merge-featur…

1c19860

…e-345-and-389-to-set-frame-range-on-animation-instance

ClementHector force-pushed the 483-merge-feature-345-and-389-to-set-frame-range-on-animation-instance branch from b6e955f to 1c19860 Compare July 6, 2023 12:07

BigRoy reviewed Jul 6, 2023

View reviewed changes

openpype/hosts/maya/api/lib.py Outdated Show resolved Hide resolved

Update openpype/hosts/maya/api/lib.py

2bf64a4

Co-authored-by: Roy Nieterau <[email protected]>

BigRoy reviewed Jul 6, 2023

View reviewed changes

tokejepsen marked this pull request as draft July 17, 2023 16:46

mkolar closed this Jan 25, 2024

ynbot added this to the next-patch milestone Jan 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge feature from #4793 and #4996 to set frame range on instances #5201

Merge feature from #4793 and #4996 to set frame range on instances #5201

ClementHector commented Jun 27, 2023 •

edited

Loading

tokejepsen commented Jun 28, 2023

Minkiu left a comment

BigRoy Jul 3, 2023

ClementHector Jul 4, 2023

BigRoy Jul 4, 2023

BigRoy Jul 6, 2023

ClementHector Jul 7, 2023

BigRoy Jul 7, 2023

iLLiCiTiT commented Jul 13, 2023

BigRoy commented Jul 13, 2023

tokejepsen commented Jan 16, 2024

mkolar commented Jan 25, 2024

		update_instances_frame_range()
		update_instances_asset_attribute()

Merge feature from #4793 and #4996 to set frame range on instances #5201

Merge feature from #4793 and #4996 to set frame range on instances #5201

Conversation

ClementHector commented Jun 27, 2023 • edited Loading

Changelog Description

Testing notes:

tokejepsen commented Jun 28, 2023

Minkiu left a comment

Choose a reason for hiding this comment

BigRoy Jul 3, 2023

Choose a reason for hiding this comment

ClementHector Jul 4, 2023

Choose a reason for hiding this comment

BigRoy Jul 4, 2023

Choose a reason for hiding this comment

BigRoy Jul 6, 2023

Choose a reason for hiding this comment

ClementHector Jul 7, 2023

Choose a reason for hiding this comment

BigRoy Jul 7, 2023

Choose a reason for hiding this comment

iLLiCiTiT commented Jul 13, 2023

BigRoy commented Jul 13, 2023

tokejepsen commented Jan 16, 2024

mkolar commented Jan 25, 2024

ClementHector commented Jun 27, 2023 •

edited

Loading