Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Refactor to new publisher #4388

Merged
merged 203 commits into from
Jul 11, 2023
Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jan 27, 2023

Brief description

Refactor Maya to use the new publisher with new creators.

Description

  • Legacy instance can be converted in UI using SubsetConvertorPlugin
    • Fix support for old style "render" and "vrayscene" instance to the new per layer format.
  • Context data is stored with scene
  • Workfile instance converted to AutoCreator
  • Converted Creator classes
    • Create animation
    • Create ass
    • Create assembly
    • Create camera
    • Create layout
    • Create look
    • Create mayascene
    • Create model
    • Create multiverse look
    • Create multiverse usd
    • Create multiverse usd comp
    • Create multiverse usd over
    • Create pointcache
    • Create proxy abc
    • Create redshift proxy
    • Create render
    • Create rendersetup
    • Create review
    • Create rig
    • Create setdress
    • Create unreal skeletalmesh
    • Create unreal staticmesh
    • Create vrayproxy
    • Create vrayscene
    • Create xgen
    • Create yeti cache
    • Create yeti rig
  • Tested new Creator publishes
    • Publish animation
    • Publish ass
    • Publish assembly
    • Publish camera
    • Publish layout
    • Publish look
    • Publish mayascene
    • Publish model
    • Publish multiverse look
    • Publish multiverse usd
    • Publish multiverse usd comp
    • Publish multiverse usd over
    • Publish pointcache
    • Publish proxy abc
    • Publish redshift proxy
    • Publish render
    • Publish rendersetup
    • Publish review
    • Publish rig
    • Publish setdress
    • Publish unreal skeletalmesh
    • Publish unreal staticmesh
    • Publish vrayproxy
    • Publish vrayscene
    • Publish xgen
    • Publish yeti cache
    • Publish yeti rig
    • Publish workfile
  • Rig loader correctly generates a new style animation creator instance
  • Validations / Error messages for common validation failures look nice and usable as a report.
  • Make Create Animation hidden to the user (should not create manually?)
  • Correctly detect difference between 'creator_attributes' and 'instance_data' since both are "flattened" to the top node.

Additional info

Here's a fun little PR - I wonder at what amount of lines of code changed we'll end.

Screenshots

Publishing:
afbeelding
afbeelding
afbeelding

New pointcache instance in attribute editor:
afbeelding

New pointcache instance in channel box:
afbeelding

Testing notes:

  1. Start Maya
  2. Publish all the things!

@BigRoy BigRoy self-assigned this Jan 27, 2023
@LiborBatek
Copy link
Member

LiborBatek commented Jun 26, 2023

When trying to publish Review from scene it got error (I have created fresh new review instance) I have also model instance nested inside review (see scrngrb)

My fps and frame range also matches the values in DB. So no mismatch in those.

image

And Review also trigger error in different scene (when trying publish from animation scene) without any nested instances inside

Seems like missing param on Review instance but there is no need to Convert Legacy Instances before triggering Publish ...user is able to run it immedeately in this case.
image

image

@antirotor
Copy link
Member

antirotor commented Jun 26, 2023

Hmm, seems like animation data are not collected from review instance but from the model where it is obviously missing it...

@LiborBatek
Copy link
Member

LiborBatek commented Jun 26, 2023

Tests so far with success

  • ass
  • model
  • rig
  • look (arnold, Vray)
  • review
  • animation
  • pointcache
  • render (arnold)

@LiborBatek
Copy link
Member

I have found an Issue when creating Look instance it has enabled both conversion MakeTx and MakeRSTexBin which then fails during Validation
image

image

and during Publish

image

I guess these should be rather turned off when creating the Look instance. One of the reasons being that even not usable for ie when using Vray renderer so these doesnt make sense then. Or to test if those renderers are enabled for rendering...

@antirotor
Copy link
Member

I've fixed the fps issue in review and default settings for look creator, so it should be ok.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it successfuly publish Review too.

image

@antirotor antirotor merged commit 0b8207a into ynput:develop Jul 11, 2023
6 checks passed
@ynbot ynbot added this to the next-patch milestone Jul 11, 2023
@tokejepsen
Copy link
Member

WTF! This is huge!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bump Minor Pull requests that update a dependency file community contribution host: Maya host: UE module: Deadline AWS Deadline related features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants