This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge feature from #4793 and #4996 to set frame range on instances #5201
Merge feature from #4793 and #4996 to set frame range on instances #5201
Changes from 12 commits
92f5046
002f2c8
062cf52
921eb4f
de4bad2
435deed
6296fc5
95b5fff
079abd0
399bbec
8c4e0b7
248a8f6
359bc65
0ec7f99
d96495e
1c19860
2bf64a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this is in the right place.
cleanup_placeholder
sounds like it runs per placeholder instead of at the very end of workfile build. We only want to run this once, right? Not every single time.I feel like this is probably in the wrong place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well seen, it is true that it is executed at each placeholder. I think we should move this to here with a
post_populate_scene_placeholders
method but we don't can't call maya commands here, maybe we should implement instance-related commands inhost
class? maybe it doesn't make sense with the new publisher (which I don't know)?Tell me what would make more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the abstract workfile builder is missing some methods that trigger before the build and after the build. We could expose a
after_build_process()
andpre_build_process()
so that each DCC could implement its own callbacks that run before or after ALL placeholders. Not sure if the best approach and whether it's really missing - but couldn't quickly find a feature that does that.Another way could be for the workfile building to emit events
emit_event("workfile.before.build")
andemit_event("workfile.after.build")
so that any module could attach callbacks to the events usingregister_event_callback
- which the host itself could do e.g. oninstall()
etc.Not sure which would be the best approach. @iLLiCiTiT @tokejepsen @antirotor thoughts?