-
Notifications
You must be signed in to change notification settings - Fork 129
Maya: Redshift Skip aov file format check for Cryptomatte #3654
Conversation
default_ext = cmds.getAttr( | ||
"redshiftOptions.imageFormat", asString=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the asString
argument since the returned values were returned as integers anyway.
It was mentioned here that the file format error isn't very clear
We could turn the integer into redshift image format labels (which is what the Attribute Editor shows) or the extensions with this: from maya import mel
def redshift_get_image_format_ext(index, as_labels=False):
if as_labels:
key = "g_redshiftImageFormatLabels"
else:
key = "g_redshiftImageFormatExtensions"
labels = mel.eval("${0}=${0}".format(key))
return labels[index] These get defined (on Redshift plug-in load or launch?) in Redshift's Let me know if I should add it in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I should add it in this PR.
I think we should add it even as static map mapping values to strings and showing it to the artist. Yes, I am traumatized by windows errors like Error 0x0004a2c12 has occured
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it fine now, thanks for that!. Before merging, I would like @m-u-r-p-h-y to test it too as my current setup is pretty much broken on Redshift side.
This validation checks the AOV file format of the AOV where the "global setting" is the setting on the Layer itself.
Technically AOV file format I think is only relevant if you are not rendering multipart (merged AOVs)? But I'm not too sure out of the top of my head how that works in Redshift. Any good ideas on how to better label this error? |
From my point of view, the wording is actually opposite. OP settings is set to TIFF so: |
You were right - the formatting was swapped. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brief description
This fixes #3410
Description
The file format check for AOVs is skipped for Cryptomatte AOVs because Redshift always write it as "Cryptomatte (EXR)" format.
Testing notes: