Maya: Redshift Skip aov file format check for Cryptomatte

[BigRoy]

Brief description

This fixes #3410

Description

The file format check for AOVs is skipped for Cryptomatte AOVs because Redshift always write it as "Cryptomatte (EXR)" format.

Testing notes:

1. Set up scene with Redshift + Cryptomatte AOV and others
2. Ensure validation works as expected for file format (extension)

[BigRoy]

I've removed the asString argument since the returned values were returned as integers anyway.

[BigRoy]

It was mentioned here that the file format error isn't very clear

@m-u-r-p-h-y : the file format error is not very clear, as the user is not aware of 1 and 6 and what format it actually represents.

We could turn the integer into redshift image format labels (which is what the Attribute Editor shows) or the extensions with this:

from maya import mel

def redshift_get_image_format_ext(index, as_labels=False):
    if as_labels:
        key = "g_redshiftImageFormatLabels"
    else:
        key = "g_redshiftImageFormatExtensions"
    labels = mel.eval("${0}=${0}".format(key))
    return labels[index]

These get defined (on Redshift plug-in load or launch?) in Redshift's Plugins/Maya/Common/scripts/redshiftCreateImageFormats.mel.

Let me know if I should add it in this PR.

[antirotor]

Let me know if I should add it in this PR.

I think we should add it even as static map mapping values to strings and showing it to the artist. Yes, I am traumatized by windows errors like Error 0x0004a2c12 has occured...

[BigRoy]

Improved the logged messages to show the readable labels for the image formats:

---

Additionally squashed some other bugs:

• cmds.getAttr("defaultRenderGlobals.imageFilePrefix") would return Noneif no value has ever been set, so I addedor ""` to ensure a string value.
• Repair for defaultRenderGlobals.animation wasn't implemented - it now is.

[antirotor]

I think it fine now, thanks for that!. Before merging, I would like @m-u-r-p-h-y to test it too as my current setup is pretty much broken on Redshift side.

[m-u-r-p-h-y]

where is the global file format taken from?

[BigRoy]

This validation checks the AOV file format of the AOV where the "global setting" is the setting on the Layer itself.
So basically you have:

• OpenPype Settings: Output Image Format - unrelated to this error actually
• Redshift Render Settings > Common > Image Format - this is the currently set 'global' file format for the layer.
• Redshift Render Settings > Advanced > AOV - each AOV also has a file format of its own. That is the AOV file format.

Technically AOV file format I think is only relevant if you are not rendering multipart (merged AOVs)? But I'm not too sure out of the top of my head how that works in Redshift.

Any good ideas on how to better label this error?

[m-u-r-p-h-y]

From my point of view, the wording is actually opposite.

OP settings is set to TIFF
Render Globals is set to TIFF
Beauty AOV is set OpenExr
Cryptomatte is set to OpenExr

so:
AOV file format OpenExr is not matching Global settings TIFF (OP + Render settings)

[BigRoy]

You were right - the formatting was swapped. Fixed.

[m-u-r-p-h-y]

the check is correctly skipping cryptomatte file format check with Redshift renderer