Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Redshift Skip aov file format check for Cryptomatte #3654

Merged
merged 7 commits into from
Sep 23, 2022
Merged

Maya: Redshift Skip aov file format check for Cryptomatte #3654

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f0a8d7
Maya Redshift: Skip aov file format check for Cryptomatte
BigRoy Aug 12, 2022
379a5f5
Log file format in more human-readable manner instead of an integer
BigRoy Sep 8, 2022
d37f65e
Fix `prefix` is None issue
BigRoy Sep 8, 2022
4d84a06
Repair defaultRenderGlobals.animation (must be enabled)
BigRoy Sep 8, 2022
fea33ee
Clarify log message which of the values is AOV format and which is gl…
BigRoy Sep 8, 2022
1f8887e
Cosmetics
BigRoy Sep 8, 2022
54d5724
Fix log formatting (global file format and aov file format were previ…
BigRoy Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions openpype/hosts/maya/plugins/publish/validate_rendersettings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,17 @@ def get_invalid(cls, instance):
redshift_AOV_prefix
))
invalid = True
# get aov format
aov_ext = cmds.getAttr(
"{}.fileFormat".format(aov), asString=True)

default_ext = cmds.getAttr(
"redshiftOptions.imageFormat", asString=True)
Comment on lines -187 to -188
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the asString argument since the returned values were returned as integers anyway.

# check aov file format
aov_ext = cmds.getAttr("{}.fileFormat".format(aov))
default_ext = cmds.getAttr("redshiftOptions.imageFormat")
aov_type = cmds.getAttr("{}.aovType".format(aov))
if aov_type == "Cryptomatte":
# redshift Cryptomatte AOV always uses "Cryptomatte (EXR)"
# so we ignore validating file format for it.
pass

if default_ext != aov_ext:
elif default_ext != aov_ext:
cls.log.error(("AOV file format is not the same "
"as the one set globally "
"{} != {}").format(default_ext,
Expand Down