Added new Permissions Extension #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37ng
reviewed
May 9, 2024
clean up admin list error checking Co-authored-by: 37ng <[email protected]>
This reverts commit 1b0cc38.
neekolas
approved these changes
May 14, 2024
neekolas
reviewed
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #664
Related proto PR: xmtp/proto#175
Breaking up Permission Updates into multiple PRs.
This PR incorporates Proto updates from xmtp/proto#175 which add a new Permissions Extension, and moves existing permissions from immutable data to this new unknown extension. We also update the Permission Preconfigured Policies from
EveryoneIsAdminandGroupCreatorOnlytoAllMembersandAdminsOnly. This update is currently invisible to the SDKs. Since the Group Creator is the only admin and super admin starting out, nothing changes for the SDKs until we add the methods for updating the admin list in the follow up PR, which will be linked here.Before Merging:
mainbranch